-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lookup: re-add winston #983
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #983 +/- ##
=======================================
Coverage 96.44% 96.44%
=======================================
Files 28 28
Lines 2139 2139
=======================================
Hits 2063 2063
Misses 76 76 ☔ View full report in Codecov by Sentry. |
Looks like the tests are passing now and this can land? |
It failed on Windows. |
Maybe we can re-add it with skipping Windows then? |
Sure, here's a full CI job: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-pipeline/258/ |
Looks like it's still failing. Oh well. Back to draft mode until someone wants to look into it or enough time has passed that it makes sense to try again. |
Checklist
npm test
passeshere