Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: drop node 16 #962

Merged
merged 3 commits into from
Sep 24, 2023
Merged

build: drop node 16 #962

merged 3 commits into from
Sep 24, 2023

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Sep 8, 2023

Node 16 is going end-of-life in September 11.

Edit: This Pr should also include package.json changes for engines field.

@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8b6acfb) 96.44% compared to head (ad17a18) 96.44%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #962   +/-   ##
=======================================
  Coverage   96.44%   96.44%           
=======================================
  Files          28       28           
  Lines        2139     2139           
=======================================
  Hits         2063     2063           
  Misses         76       76           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anonrig anonrig marked this pull request as draft September 8, 2023 17:29
@Trott
Copy link
Member

Trott commented Sep 21, 2023

@anonrig Do you want to update package.json and take this out of draft mode?

@Trott Trott marked this pull request as ready for review September 24, 2023 14:17
@Trott Trott merged commit 5ed8640 into main Sep 24, 2023
8 checks passed
@Trott Trott deleted the drop-node-16 branch September 24, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants