Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lookup: avoid browser testing for through2 #810

Merged
merged 2 commits into from
Jul 1, 2020

Conversation

richardlau
Copy link
Member

Use a different npm script to avoid browser tests for through2 and sort
the keys for the through2 entry in lookup.json.

Fixes: #809

Checklist
  • npm test passes
  • contribution guidelines followed
    here

Use a different npm script to avoid browser tests for through2 and sort
the keys for the through2 entry in lookup.json.
@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2020

Codecov Report

Merging #810 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #810   +/-   ##
=======================================
  Coverage   96.17%   96.17%           
=======================================
  Files          30       30           
  Lines         889      889           
=======================================
  Hits          855      855           
  Misses         34       34           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fae841...e053c80. Read the comment docs.

@richardlau
Copy link
Member Author

CI: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-pipeline/118/flowGraphTable/

(Looks like failures on AIX and Windows)

@richardlau
Copy link
Member Author

richardlau commented Jul 1, 2020

Added skips for AIX and Windows.

New CI: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-pipeline/119/flowGraphTable/
(citgm doesn't honour skip/flaky).
Retrying with citgm-all: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-pipeline/120/flowGraphTable/ (✔️)

@richardlau richardlau merged commit cd99a99 into nodejs:master Jul 1, 2020
@richardlau richardlau deleted the through2 branch July 1, 2020 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

citgm.through2-v4.0.1 failing on multiple platforms
3 participants