Latest CITGM results #997

RafaelGSS · 2023-10-02T13:47:44Z

running - main - https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3299/testReport/
15 failures v20.x - https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3297/testReport/ (related nan tests fail on three platforms with Node.js 20.x #996)
running - v18.x - https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3298/testReport/

Let's use this issue to list failing modules and take action such as removing offending modules, skip specific arches and so on

@nodejs/citgm

ljharb · 2023-10-02T13:55:11Z

tape failed on rhel8-ppc64le due to a timeout; i suspect with a longer timeout it'd pass.

alfonsograziano · 2023-10-02T13:57:29Z

I just had a nice chat with @RafaelGSS. Will look into it :)

alfonsograziano · 2023-10-02T14:32:34Z

Regarding this test fail.
On my machine works fine with these specifications:

Node v20.8 (as in the CI run)
underscore-v1.13.6 (as in the CI run)
macOs version 13.6

Command run: citgm [email protected]
The tests are not flacky on this package.

alfonsograziano · 2023-10-02T14:45:39Z

All the issues regarding macOS are not reproducible for me locally. I'm using the correct Node version and the correct package version, the tests are not failing on my machine. @nodejs/build

RafaelGSS · 2023-10-02T15:19:44Z

Let's wait v18.x and main to see if the same happens for these versions. But, I guess that's something related to our machines.

Trott · 2023-10-02T17:55:52Z

The failures on three platforms for nan already has an issue (#996). It would be great if someone could figure that one out. (I haven't looked and don't have the right expertise probably anyway.)

EDIT: Oh, I see @RafaelGSS already linked to it in the description. I'd love to see someone get to the bottom of that one.

Trott · 2023-10-02T17:57:16Z

The macOS failures have a PR that might be worth landing just to bypass things for straightforward JavaScript modules.

#971

Trott · 2023-10-02T18:04:12Z

tape failed on rhel8-ppc64le due to a timeout; i suspect with a longer timeout it'd pass.

@ljharb Is it possible to pass a longer timeout value via the command line? Something along the lines of npm run tests-only -- --timeout=99999? If so, it would just be a matter of updating line 483 of lookup.json.

citgm/lib/lookup.json

Line 483 in cd1b288

"scripts": ["tests-only"],

alfonsograziano · 2023-10-03T06:59:21Z

Is really interesting to notice that in the last run on main there are no issues over macOS even without the skip applied, but on v18.18 there are 6 errors.

I managed to reproduce the issue over [email protected] and also the multer issue. The multer one is flaky on my machine, here is the PR to fix it

alfonsograziano · 2023-10-03T07:37:25Z

@ljharb probably also semver failed due to a timeout. Shall we try to increase it or set it as flaky due to tests timeout?

ruyadorno · 2023-10-03T13:38:01Z

Please keep the max timeout to a reasonable amount. We don't want to end up with a citgm run that takes forever to timeout when something got stuck in the test.

ruyadorno · 2023-10-03T13:44:03Z

I managed to reproduce the issue over [email protected] and also the multer issue. The multer one is flaky on my machine, here is the PR to fix it

While that's a good short-term solution to the problem, an actual fix should hopefully land in either multer or node so that it stop failing on macos. In these cases please open an issue pinging the maintainer - you can find it by browsing lookup.json e.g:

citgm/lib/lookup.json

Lines 337 to 341 in cd1b288

    
           "multer": { 
        
             "prefix": "v", 
        
             "skip": "win32", 
        
             "maintainers": "linusu" 
        
           },

Here's an example of an issue pinging the maintainer of a package for help: #988. Keep in mind you might be able to post more info, since you're able to reproduce in your machine you might be able to add some helpful logs or maybe test which combinations of package version + node version it fails vs succeeds, etc.

Thanks for the help @alfonsograziano it's really appreciated! 🙏

alfonsograziano · 2023-10-06T13:39:05Z

Here are a few issues/PRs open now to fix these issues:

RafaelGSS · 2023-10-06T13:54:34Z

After merging both PRs:

main CITGM https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3307/

alfonsograziano · 2023-10-08T06:21:35Z

After the latest run on v18.18, we have 14 issues.

torrent-stream: we have already chore: remove torrent-stream #1001 to fix this issue. The package will be removed as required from the maintainer in [email protected] #1000. @RafaelGSS can you please merge the PR? :)
multer: the package is still failing on 3 platforms including macOS, even after lookup: will make multer flaky on macOS #998 has been merged. I have no idea why is still failing. If continue to fail, shall we make it flaky on all the platforms that are failing now?
nan: still failing, I proposed to skip on the failing platforms on nan tests fail on three platforms with Node.js 20.x #996. Addressed in chore: skip nan on some platforms #1005
leveldown: install failed (macOS) chore: skip failing packages on macOS #1006
microtime: install failed (macOS) chore: skip failing packages on macOS #1006
bufferutil: install failed (macOS) chore: skip failing packages on macOS #1006
underscore: 2 tests failed on macOS, cannot reproduce on my mac. chore: disable underscore on macOS #1008
pino: Discussion on chore: mark pino as flaky #1002
semver: failed for timeout, issued chore: increased semver timeout #1004 to fix it

alfonsograziano · 2023-10-08T07:24:16Z

After the latest run on v21.0.0, we have 14 issues.

nan: as above, addressed in chore: skip nan on some platforms #1005
torrent-stream: as above, addressed in chore: remove torrent-stream #1001
express-session: 1 test failure
jest: ENOSPC: no space left on device. Do we know how to fix it? @RafaelGSS
import-in-the-middle: Discussion happening in import-in-the-middle failing on Node.js main branch #995

RafaelGSS · 2023-10-08T15:36:19Z

For the install failing, I think we should just drop these packages if we confirm these failures aren't machine-related.

jest: ENOSPC: no space left on device. Do we know how to fix it? @RafaelGSS

Usually, we open an issue on nodejs/build.

alfonsograziano · 2023-10-09T06:19:57Z

For the install failing:

Failed on 3310
Failed on 3309
Failed on 3300

They are always failing on v18.18 but I cannot reproduce the failure on my local machine.
#1006 will skip them for now on OSX and at the same time will create an issue to find a proper solution :)

Usually, we open an issue on nodejs/build.

Done here:
nodejs/build#3512
Outcome: The space has been increased by deleting some files, we now have more than 5gb free. Hopefully shouldn't happen in the next run

RafaelGSS · 2023-10-09T15:13:28Z

Next run: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3316/ - long queue - we should wait a bit

alfonsograziano · 2023-10-10T07:37:58Z

@RafaelGSS I'm not sure if this run is correct, there are still errors from torrent-stream that has been removed entirely from the lookup

richardlau · 2023-10-10T11:43:45Z

@RafaelGSS I'm not sure if this run is correct, there are still errors from torrent-stream that has been removed entirely from the lookup

The CI job runs by default on published versions of CITGM -- there hasn't been a release with the changes to the lookup.

RafaelGSS · 2023-10-10T11:52:30Z

@RafaelGSS I'm not sure if this run is correct, there are still errors from torrent-stream that has been removed entirely from the lookup

The CI job runs by default on published versions of CITGM -- there hasn't been a release with the changes to the lookup.

Should I use nodejs/citgm#main on

?

UPDATE: Running https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3318

alfonsograziano · 2023-10-11T08:52:11Z

The current status after this run is: 15 failures on these packages:

import-in-the-middle: failed on all the platforms. Asked for maintainers support in import-in-the-middle failing on Node.js main branch #995
ava: failed on ubuntu, debian. Asked for maintainers support in [email protected] not working on Node v21.x #1012. I'm a little concerned by the fact that this module is already skipped on a lot of platforms, maybe the issue that is triggered on the two platforms can affect other platforms as well.
jose: failed on ubuntu, rhel8-s390x, rhel8-ppc64le, debian10-x64, rhel8-x64. Asked for maintainers support in [email protected] not working on Node v21.x #1011
semver: failed on rhel8-ppc64le - increase timeout proposed in Semver timeout increased for single test #1013. Not sure if this is the best solution to the problem
jest: failed on debian - test timed out after 33 minutes. I see that in the lookup we have a 30 mins timeout. Is there any reason for such a long timeout on this module?

RafaelGSS · 2023-11-30T14:57:34Z

It seems we got a green CI for LTS release lines. I'm opening #1033 for v21 failures.

Trott mentioned this issue Oct 2, 2023

remove macOS for most projects #971

Open

4 tasks

This comment was marked as resolved.

Sign in to view

BethGriggs mentioned this issue Nov 22, 2023

Check if citgm is clean on Node master #660

Closed

RafaelGSS closed this as completed Nov 30, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Latest CITGM results #997

Latest CITGM results #997

RafaelGSS commented Oct 2, 2023 •

edited

Loading

ljharb commented Oct 2, 2023

alfonsograziano commented Oct 2, 2023

alfonsograziano commented Oct 2, 2023 •

edited

Loading

alfonsograziano commented Oct 2, 2023

RafaelGSS commented Oct 2, 2023

Trott commented Oct 2, 2023 •

edited

Loading

Trott commented Oct 2, 2023

Trott commented Oct 2, 2023

alfonsograziano commented Oct 3, 2023 •

edited

Loading

alfonsograziano commented Oct 3, 2023

ruyadorno commented Oct 3, 2023 •

edited

Loading

ruyadorno commented Oct 3, 2023

alfonsograziano commented Oct 6, 2023

RafaelGSS commented Oct 6, 2023

alfonsograziano commented Oct 8, 2023 •

edited

Loading

alfonsograziano commented Oct 8, 2023 •

edited

Loading

RafaelGSS commented Oct 8, 2023

alfonsograziano commented Oct 9, 2023 •

edited

Loading

RafaelGSS commented Oct 9, 2023

alfonsograziano commented Oct 10, 2023

richardlau commented Oct 10, 2023

RafaelGSS commented Oct 10, 2023 •

edited

Loading

alfonsograziano commented Oct 11, 2023 •

edited

Loading

This comment was marked as resolved.

RafaelGSS commented Nov 30, 2023

Latest CITGM results #997

Latest CITGM results #997

Comments

RafaelGSS commented Oct 2, 2023 • edited Loading

ljharb commented Oct 2, 2023

alfonsograziano commented Oct 2, 2023

alfonsograziano commented Oct 2, 2023 • edited Loading

alfonsograziano commented Oct 2, 2023

RafaelGSS commented Oct 2, 2023

Trott commented Oct 2, 2023 • edited Loading

Trott commented Oct 2, 2023

Trott commented Oct 2, 2023

alfonsograziano commented Oct 3, 2023 • edited Loading

alfonsograziano commented Oct 3, 2023

ruyadorno commented Oct 3, 2023 • edited Loading

ruyadorno commented Oct 3, 2023

alfonsograziano commented Oct 6, 2023

RafaelGSS commented Oct 6, 2023

alfonsograziano commented Oct 8, 2023 • edited Loading

alfonsograziano commented Oct 8, 2023 • edited Loading

RafaelGSS commented Oct 8, 2023

alfonsograziano commented Oct 9, 2023 • edited Loading

RafaelGSS commented Oct 9, 2023

alfonsograziano commented Oct 10, 2023

richardlau commented Oct 10, 2023

RafaelGSS commented Oct 10, 2023 • edited Loading

alfonsograziano commented Oct 11, 2023 • edited Loading

This comment was marked as resolved.

RafaelGSS commented Nov 30, 2023

RafaelGSS commented Oct 2, 2023 •

edited

Loading

alfonsograziano commented Oct 2, 2023 •

edited

Loading

Trott commented Oct 2, 2023 •

edited

Loading

alfonsograziano commented Oct 3, 2023 •

edited

Loading

ruyadorno commented Oct 3, 2023 •

edited

Loading

alfonsograziano commented Oct 8, 2023 •

edited

Loading

alfonsograziano commented Oct 8, 2023 •

edited

Loading

alfonsograziano commented Oct 9, 2023 •

edited

Loading

RafaelGSS commented Oct 10, 2023 •

edited

Loading

alfonsograziano commented Oct 11, 2023 •

edited

Loading