Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if citgm is clean on Node master #660

Closed
targos opened this issue Dec 15, 2018 · 19 comments
Closed

Check if citgm is clean on Node master #660

targos opened this issue Dec 15, 2018 · 19 comments

Comments

@targos
Copy link
Member

targos commented Dec 15, 2018

CI run: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1688/

I expect it to fail on Windows because of #652 but if other platforms are red, we should look into the failures.

@targos
Copy link
Member Author

targos commented Dec 15, 2018

iconv is handled in bnoordhuis/node-iconv#194 and bnoordhuis/node-iconv#189

@targos
Copy link
Member Author

targos commented Dec 15, 2018

tape fails because it apparently does not support to run on a node-pre version:

 /home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/citgm_tmp/83f5bbf7-0f6d-46d9-b25b-0c18ea8722f9/tape/node_modules/parse-node-version/index.js:6
     throw new Error('Unable to parse: ' + version);
     ^
 Error: Unable to parse: v12.0.0-pre
     at parseNodeVersion (/home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/citgm_tmp/83f5bbf7-0f6d-46d9-b25b-0c18ea8722f9/tape/node_modules/parse-node-version/index.js:6:11)
     at Object.<anonymous> (/home/iojs/build/workspace/citgm-smoker/nodes/debian8-64/citgm_tmp/83f5bbf7-0f6d-46d9-b25b-0c18ea8722f9/tape/node_modules/fancy-log/index.js:7:48)

@targos
Copy link
Member Author

targos commented Dec 15, 2018

I added sqlite3, leveldown and level to the list in nodejs/node#25060

@targos
Copy link
Member Author

targos commented May 14, 2019

New run with version 5.0.2: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1848/

@targos
Copy link
Member Author

targos commented May 18, 2019

@targos
Copy link
Member Author

targos commented Jun 18, 2019

@targos
Copy link
Member Author

targos commented Oct 23, 2019

@Trott
Copy link
Member

Trott commented Oct 23, 2019

https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2075/

failed hosts in CI package notes [edit freely]
8 citgm.csv-parser-v2.3.1 fix in master but not release /ping @shellscape
6 citgm.serialport-v7.1.5 serialport is expected to work with master when 8.x comes out of beta. Not sure what the expected release date is. /ping @reconbot
5 citgm.zeromq-v5.1.1 update is in progress. /ping @rolftimmermans
1 citgm.underscore-v1.9.1
1 citgm.torrent-stream-v1.2.0
1 citgm.socket.io-v2.3.0
1 citgm.radium-v0.26.0
1 citgm.ember-cli-v3.13.1
1 citgm.coffeescript-v2.4.1
1 citgm.acorn-v7.1.0

@targos targos changed the title Check if citgm in clean on Node master Check if citgm is clean on Node master Oct 23, 2019
@Trott
Copy link
Member

Trott commented Oct 23, 2019

I believe the csv-parser failures will go away once a new version of csv-parser is published. The fix for it is in master, but not in a release. /ping @shellscape

@shellscape
Copy link

My OSS backlog is massive right now. A house renovation and 8 month old teething transition to solid food crazy poop child is taking up most of my free time. I'm picking things off as I have the chance to. Gonna be a bit folks.

@Trott
Copy link
Member

Trott commented Oct 23, 2019

serialport is expected to work with master when 8.x comes out of beta. Not sure what the expected release date is. /ping @reconbot

@Trott
Copy link
Member

Trott commented Oct 23, 2019

For zeromq, from nodejs/node#29504 (comment):

@rolftimmermans has a next generation version here that is on the roadmap to be merged back to master!

@richardlau
Copy link
Member

FWIW here's another run against master (used to test some changes to the CI job): https://ci.nodejs.org/job/citgm-smoker/2078/

@reconbot
Copy link
Contributor

@Trott got the release out today [email protected]

@Trott
Copy link
Member

Trott commented Oct 28, 2019

Here's another one: https://ci.nodejs.org/job/citgm-smoker/2079/

failed hosts in CI package notes [edit freely]
10 citgm.csv-parser-v2.3.1 fix in master but not released yet
6 citgm.zeromq-v5.1.1 update is in progress
3 citgm.torrent-stream-v1.2.0
2 citgm.winston-v3.2.1
2 citgm.ember-cli-v3.13.1
1 citgm.spawn-wrap-v1.4.3
1 citgm.socket.io-v2.3.0
1 citgm.pug-v2.0.4
1 citgm.coffeescript-v2.4.1

@shellscape
Copy link

csv-parser has been updated

@Trott
Copy link
Member

Trott commented Nov 8, 2019

https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2085/

failed hosts in CI package notes [edit freely]
8 citgm.torrent-stream-v1.2.0 looks like this is partially or entirely a problem with mout? mout/mout#261
6 citgm.zeromq-v6.0.0-beta.2 #770
5 citgm.commander-v4.0.0
2 citgm.ember-cli-v3.13.1
1 citgm.winston-v3.2.1
1 citgm.socket.io-v2.3.0
1 citgm.pug-v2.0.4
1 citgm.coffeescript-v2.4.1

@Trott
Copy link
Member

Trott commented Nov 8, 2019

mout v1.2.1 was released a few hours ago. It should fix some (or maybe even all) of our torrent-stream problems and possibly other issues.

https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2086/

failed hosts in CI package notes [edit freely]
6 citgm.zeromq-v6.0.0-beta.3 #770
2 citgm.torrent-stream-v1.2.0
2 citgm.ember-cli-v3.13.1
2 citgm.commander-v4.0.0
1 citgm.winston-v3.2.1
1 citgm.multer-v1.4.2
1 citgm.coffeescript-v2.4.1

@BethGriggs
Copy link
Member

Closing as stale and superseded by the most recent review in #997

@BethGriggs BethGriggs closed this as not planned Won't fix, can't repro, duplicate, stale Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants