-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: switch to ESM, fix output colourising, dedupe more code w/ branch-diff #121
Conversation
613718e
to
286d2a1
Compare
Also remove Node.js v12 support Ref: nodejs/changelog-maker#121
LGTM but I'm not a releaser so I'm not sure if/how this impacts their process.... |
I think switching the default would mean we'd have to update https://github.com/nodejs/node-core-utils/blob/e7a95a4ec4b166b9311c673f1d4617da4a13d2bc/lib/prepare_release.js#L291-L303 when we update https://github.com/nodejs/node-core-utils/blob/d1c52e669439dbe22bc902cfa5d767328b91b06b/package.json#L36. I haven't really used that aspect of
Lazy way to try it out
|
…nch-diff * upgrade all deps, including ESM-only deps * --simple is now default output, including colourising, with --markdown being an opt-in output format. * move process + print logic to separate module for exporting for simplifying branch-diff * add --sha and --reverse options from branch-diff to dedupe some processing code Fixes: #120 Closes: #107 Closes: #119
Whoa this didn't get merged, I forgot all about it. @nodejs/releasers heads-up this is going out as a 3.0.0 and you'll need a |
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Also remove Node.js v12 support Ref: nodejs/changelog-maker#121
Also remove Node.js v12 support Ref: nodejs/changelog-maker#121
The biggest change is that second item, the default output is nice for the terminal but if you want it for changelogs then you'll need to
--md
to get it and you won't have colourisation for that. The new markdown formatter and ansi don't mix. So this change will require some @nodejs/releasers input.Change set is probably a bit for a full review, but if you're interested then maybe clone it and
npm link
it to try it out.Fixes: #120
Closes: #107
Closes: #119