ansible: support for Ubuntu 14.04 #735

joaocgreis · 2017-05-25T02:13:04Z

This adds a few adjustments needed to create a Jenkins worker on Ubuntu 14.04.

The second commit is necessary because there is already a package name specified for Ubuntu, which is not available on 14.04. With the when statement, Ansible prints a warning and then ignores the failure installing the package.

cc @jbergstroem

Ansible warns that when statements should not include jinja2 templating delimiters, and ignores subsequent failures installing the package. This lets the package installation fail when the package name is missing.

seishun · 2017-07-05T21:12:11Z

ERROR! Syntax Error while loading YAML.


The error appears to have been in '/mnt/c/Users/Nikolai/build/ansible/roles/baselayout/vars/main.yml': line 110, column 3, but may
be elsewhere in the file depending on the exact syntax problem.

The offending line appears to be:


  ubuntu1404: [
  ^ here

It seems there's a missing comma.

joaocgreis · 2017-07-06T10:36:47Z

@seishun should be fixed, thanks!

seishun · 2017-07-07T12:11:19Z

TASK [baselayout : install packages] ***********************************************************************************
failed: [test-softlayer-ubuntu1404-x64-1] (item=ntp) => {"cache_update_time": 1499117895, "cache_updated": false, "failed": true, "msg": "'/usr/bin/apt-get -y -o \"Dpkg::Options::=--force-confdef\" -o \"Dpkg::Options::=--force-confold\"     install 'ntp'' failed: E: Failed to fetch http://security.ubuntu.com/ubuntu/pool/main/n/ntp/ntp_4.2.6.p5+dfsg-3ubuntu2.14.04.10_amd64.deb  404  Not Found [IP: 91.189.91.26 80]\n\nE: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?\n", "package": "ntp", "rc": 100, "stderr": "E: Failed to fetch http://security.ubuntu.com/ubuntu/pool/main/n/ntp/ntp_4.2.6.p5+dfsg-3ubuntu2.14.04.10_amd64.deb  404  Not Found [IP: 91.189.91.26 80]\n\nE: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?\n", "stderr_lines": ["E: Failed to fetch http://security.ubuntu.com/ubuntu/pool/main/n/ntp/ntp_4.2.6.p5+dfsg-3ubuntu2.14.04.10_amd64.deb  404  Not Found [IP: 91.189.91.26 80]", "", "E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?"], "stdout": "Reading package lists...\nBuilding dependency tree...\nReading state information...\nThe following extra packages will be installed:\n  libopts25\nSuggested packages:\n  ntp-doc\nThe following NEW packages will be installed:\n  libopts25 ntp\n0 upgraded, 2 newly installed, 0 to remove and 0 not upgraded.\nNeed to get 477 kB of archives.\nAfter this operation, 1682 kB of additional disk space will be used.\nGet:1 http://archive.ubuntu.com/ubuntu/ trusty/main libopts25 amd64 1:5.18-2ubuntu2 [55.3 kB]\nErr http://archive.ubuntu.com/ubuntu/ trusty-updates/main ntp amd64 1:4.2.6.p5+dfsg-3ubuntu2.14.04.10\n  404  Not Found [IP: 91.189.88.162 80]\nErr http://security.ubuntu.com/ubuntu/ trusty-security/main ntp amd64 1:4.2.6.p5+dfsg-3ubuntu2.14.04.10\n  404  Not Found [IP: 91.189.91.26 80]\nFetched 55.3 kB in 0s (57.2 kB/s)\n", "stdout_lines": ["Reading package lists...", "Building dependency tree...", "Reading state information...", "The following extra packages will be installed:", "  libopts25", "Suggested packages:", "  ntp-doc", "The following NEW packages will be installed:", "  libopts25 ntp", "0 upgraded, 2 newly installed, 0 to remove and 0 not upgraded.", "Need to get 477 kB of archives.", "After this operation, 1682 kB of additional disk space will be used.", "Get:1 http://archive.ubuntu.com/ubuntu/ trusty/main libopts25 amd64 1:5.18-2ubuntu2 [55.3 kB]", "Err http://archive.ubuntu.com/ubuntu/ trusty-updates/main ntp amd64 1:4.2.6.p5+dfsg-3ubuntu2.14.04.10", "  404  Not Found [IP: 91.189.88.162 80]", "Err http://security.ubuntu.com/ubuntu/ trusty-security/main ntp amd64 1:4.2.6.p5+dfsg-3ubuntu2.14.04.10", "  404  Not Found [IP: 91.189.91.26 80]", "Fetched 55.3 kB in 0s (57.2 kB/s)"]}
changed: [test-softlayer-ubuntu1404-x64-1] => (item=ccache)
changed: [test-softlayer-ubuntu1404-x64-1] => (item=g++)
ok: [test-softlayer-ubuntu1404-x64-1] => (item=gcc)
changed: [test-softlayer-ubuntu1404-x64-1] => (item=git)
changed: [test-softlayer-ubuntu1404-x64-1] => (item=automake)
ok: [test-softlayer-ubuntu1404-x64-1] => (item=bash)
changed: [test-softlayer-ubuntu1404-x64-1] => (item=libtool)
ok: [test-softlayer-ubuntu1404-x64-1] => (item=sudo)

It seems an apt-get update is required before installing packages.

seishun · 2017-07-15T21:08:36Z

If I manually run apt-get update before running the script, I get the following:

RUNNING HANDLER [baselayout : restart sshd] ****************************************************************************
fatal: [test-softlayer-ubuntu1404-x64-1]: FAILED! => {"changed": false, "failed": true, "msg": "Could not find the requested service sshd: host"}

It seems you have to use ssh on Ubuntu 14.04. Later versions have sshd as an alias for ssh.

The role package-upgrade should run before baselayout, to ensure that the package databases are updated and baselayout can install packages.

joaocgreis · 2017-08-26T00:20:27Z

Updated. Added 2 commits:

Run package-upgrade before baselayout, to ensure apt-get update is run before installing packages. This fixes the error reported above. I only tested the jenkins worker playbook, but others should have the same issue.
Increase the timeout for downloading slave.jar: because it takes about 40 seconds and the default timeout is 10.

@seishun I did not run into the issue with ssh/sshd. I used a freshly installed ubuntu-14.04-server-amd64.iso (14.04.0, not one of the updates, to make sure the package installation would fail). At this point it would be better to land this and follow up in a new issue if you want, but please let me know if you would like this to be resolved here.

seishun · 2017-08-26T11:48:22Z

I still get the "Could not find the requested service sshd: host" error. I'm using the latest "ubuntu/trusty64" Vagrant box.

How are you testing this? Did you install the iso manually in a VM? If so, could you provide the steps you followed to configure ssh etc?

seishun · 2017-08-26T14:10:46Z

I just installed ubuntu-14.04-server-amd64.iso in a VM and service --status-all doesn't list sshd, only ssh.

joaocgreis · 2017-08-26T16:20:54Z

The handler only runs when lineinfile finds the line, so I added it to sshd_config and was able to reproduce. Added a commit to address it. @seishun let me know if this works!

For reference, I installed the iso directly in a VM, selected the OpenSSH server when installing, and added my key to root. Then on my base machine edited the inventory adding a new machine that pointed to it and added a dummy host_vars file.

seishun · 2017-08-26T17:38:01Z

Runs successfully now.

joaocgreis · 2017-08-28T03:49:40Z

@nodejs/build can you PTAL at the last 3 commits? Both @seishun and myself tested this, so I feel confident landing with just a rubber stamp.

PR-URL: #735 Reviewed-By: Kyle Farnung <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>

Ansible warns that when statements should not include jinja2 templating delimiters, and ignores subsequent failures installing the package. This lets the package installation fail when the package name is missing. PR-URL: #735 Reviewed-By: Kyle Farnung <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>

The role package-upgrade should run before baselayout, to ensure that the package databases are updated and baselayout can install packages. PR-URL: #735 Reviewed-By: Refael Ackermann <[email protected]>

PR-URL: #735 Reviewed-By: Refael Ackermann <[email protected]>

joaocgreis · 2017-08-29T18:02:55Z

Landed in 9614094...0707dc2

joaocgreis added 2 commits May 25, 2017 02:39

ansible: support for Ubuntu 14.04

40c5b74

ansible: do not use when to detect Java

d7507c5

Ansible warns that when statements should not include jinja2 templating delimiters, and ignores subsequent failures installing the package. This lets the package installation fail when the package name is missing.

This comment was marked as off-topic.

Sign in to view

gibfahn force-pushed the master branch from b646633 to 388499d Compare May 28, 2017 18:08

This comment was marked as off-topic.

Sign in to view

fixup 40c5b74: move ntp to required packages

f049f78

This comment was marked as off-topic.

Sign in to view

kunalspathak mentioned this pull request Jun 19, 2017

Install clang on benchmarking machine nodejs/benchmarking#116

Closed

jbergstroem mentioned this pull request Jun 30, 2017

move 'ubuntu1404' from systemd to upstart #779

Closed

joaocgreis mentioned this pull request Jul 4, 2017

GCC version on debian7-arm hosts #770

Closed

fixup f049f78: missing comma

4fcb941

seishun mentioned this pull request Jul 16, 2017

ansible: use gcc 4.9 on Ubuntu 14.04 #797

Closed

joaocgreis added 2 commits August 25, 2017 19:50

ansible: run package-upgrade before baselayout

e04096c

The role package-upgrade should run before baselayout, to ensure that the package databases are updated and baselayout can install packages.

ansible: increase timeout for downloading slave.jar

2b30584

ansible,ubuntu1404: restart 'ssh' instead of 'sshd'

e2906c1

This comment was marked as off-topic.

Sign in to view

joaocgreis added a commit that referenced this pull request Aug 29, 2017

ansible: increase timeout for downloading slave.jar

22d62f8

PR-URL: #735 Reviewed-By: Refael Ackermann <[email protected]>

joaocgreis added a commit that referenced this pull request Aug 29, 2017

ansible,ubuntu1404: restart 'ssh' instead of 'sshd'

0707dc2

PR-URL: #735 Reviewed-By: Refael Ackermann <[email protected]>

joaocgreis closed this Aug 29, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ansible: support for Ubuntu 14.04 #735

ansible: support for Ubuntu 14.04 #735

joaocgreis commented May 25, 2017

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

seishun commented Jul 5, 2017

joaocgreis commented Jul 6, 2017

seishun commented Jul 7, 2017

seishun commented Jul 15, 2017

joaocgreis commented Aug 26, 2017

seishun commented Aug 26, 2017 •

edited

Loading

seishun commented Aug 26, 2017

joaocgreis commented Aug 26, 2017

seishun commented Aug 26, 2017

joaocgreis commented Aug 28, 2017

This comment was marked as off-topic.

joaocgreis commented Aug 29, 2017

ansible: support for Ubuntu 14.04 #735

ansible: support for Ubuntu 14.04 #735

Conversation

joaocgreis commented May 25, 2017

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

seishun commented Jul 5, 2017

joaocgreis commented Jul 6, 2017

seishun commented Jul 7, 2017

seishun commented Jul 15, 2017

joaocgreis commented Aug 26, 2017

seishun commented Aug 26, 2017 • edited Loading

seishun commented Aug 26, 2017

joaocgreis commented Aug 26, 2017

seishun commented Aug 26, 2017

joaocgreis commented Aug 28, 2017

This comment was marked as off-topic.

joaocgreis commented Aug 29, 2017

seishun commented Aug 26, 2017 •

edited

Loading