build: changes to support ubuntu 14 for PPC BE #382
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ubuntu PPC BE defaults to 32 bit compiles as opposed to the rest of the distros (including PPC LE) which default to 64 bit. This is the case even though the OS is 64 bit. The net is that since we want to ship/support 64 bit binaries we need to install the multi-lib package and only do that for PPC BE. Looking at the ansible vars there does not seem to be one that can be used to identify between BE versus LE so I first check that we are on PPC from the vars which are available, and if we are PPC then use the node name (which includes PPC64_be for be machines) to figure out if it is BE or LE. This change adds the required changes to support BE ubuntu machines as well as the definition of the initial ubuntu BE machine
10 tasks
|
@jbergstroem I added the 2nd test and release machine so I think this is ready to go |
|
LGTM |
mhdawson
added a commit
that referenced
this pull request
Apr 12, 2016
ubuntu PPC BE defaults to 32 bit compiles as opposed to the rest of the distros (including PPC LE) which default to 64 bit. This is the case even though the OS is 64 bit. The net is that since we want to ship/support 64 bit binaries we need to install the multi-lib package and only do that for PPC BE. Looking at the ansible vars there does not seem to be one that can be used to identify between BE versus LE so I first check that we are on PPC from the vars which are available, and if we are PPC then use the node name (which includes PPC64_be for be machines) to figure out if it is BE or LE. This change adds the required changes to support BE ubuntu machines as well as the definition of the initial ubuntu BE machine PR-URL: #382 Reviewed-By: Johan Bergstroem <[email protected]>
|
Landed as b8a9401 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ubuntu PPC BE defaults to 32 bit compiles as opposed to
the rest of the distros (including PPC LE) which default to 64
bit. This is the case even though the OS is 64 bit. The
net is that since we want to ship/support 64 bit binaries we
need to install the multi-lib package and only do that
for PPC BE. Looking at the ansible vars there does not
seem to be one that can be used to identify between
BE versus LE so I first check that we are on PPC from the
vars which are available, and if we are PPC then use
the node name (which includes PPC64_be for be machines)
to figure out if it is BE or LE.
This change adds the required changes to support BE
ubuntu machines as well as the definition of the
initial ubuntu BE machine