Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jenkins: run ARM64 Windows tests on Node.js >=19 #3250

Merged
merged 1 commit into from
Mar 28, 2023
Merged

jenkins: run ARM64 Windows tests on Node.js >=19 #3250

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions jenkins/scripts/VersionSelectorScript.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ def buildExclusions = [
[ /vs2017-x86$/, testType, ltGte(10, 14) ],
[ /vs2019-x86$/, testType, lt(14) ],
[ /vs2019-arm64$/, testType, lt(14) ],
[ /COMPILED_BY-\w+-arm64$/, testType, lt(19) ], // run tests on arm64 for >=19
// VS versions supported to build add-ons
[ /vs2013-COMPILED_BY/, testType, gte(9) ],
[ /vs2015-COMPILED_BY/, testType, gte(19) ],
Expand Down Expand Up @@ -191,12 +192,5 @@ combinations.each{
return
}
}
// Run tests on Windows ARM64 only if explicitly requested
if (builderLabel =~ /^win.*COMPILED_BY.*-arm64$/) {
if (!new String(parameters['RUN_ARM64_TESTS']).equalsIgnoreCase("true")){
println "Skipping $builderLabel because RUN_ARM64_TESTS is not selected"
return
}
}
result['nodes'].add(it)
}