Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jenkins: add workaround for groovy script & Java 11+ #3019

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

richardlau
Copy link
Member

@richardlau richardlau commented Aug 25, 2022

The Matrix Groovy Execution Strategy plugin appears to have an issue
on Java 11+ where string parameters are appearing as byte arrays
instead of strings. Use the new String() constructor instead of
toString() to ensure we get string repesentation of the parameter.

Refs: jenkinsci/matrix-groovy-execution-strategy-plugin#20
Refs: #2984 (comment)

We need this to unblock the Java update.

The Matrix Groovy Execution Strategy plugin appears to have an issue
on Java 11+ where string parameters are appearing as byte arrays
instead of strings. Use the new String() constructor instead of
toString() to ensure we get string repesentation of the parameter.

Refs: jenkinsci/matrix-groovy-execution-strategy-plugin#20
Copy link
Member

@BethGriggs BethGriggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not in build, but an approval if it helps unblock the update

@richardlau richardlau merged commit dce00d0 into nodejs:main Aug 25, 2022
@richardlau richardlau deleted the groovy branch August 25, 2022 20:12
sxa added a commit to sxa/nodebuild that referenced this pull request Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants