Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Ubuntu host setup #30

Merged
merged 1 commit into from
Jan 12, 2015
Merged

Added Ubuntu host setup #30

merged 1 commit into from
Jan 12, 2015

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Jan 7, 2015

  • 14.10 64
  • 14.04 64 & 32 + GYP version for libuv
  • 12.04 64
  • 10.04 64 & 32

@rmg
Copy link

rmg commented Jan 9, 2015

The multiple copies of the readme and host variables is clearly intentional.. But I don't know the reason.

Other than my own curiosity, LGTM.

@rvagg
Copy link
Member Author

rvagg commented Jan 9, 2015

@rmg yeah, there's lots of duplication here and I'd love someone to help combine it into a single "setup all ubuntu hosts" directory with a single ansible script that just does things a little different for them all. I really just took the easiest path, which was a cp -a to get this all working. There's small variations on each of these.

The host variables need to be different because each one has a secret that's unique.

@rmg
Copy link

rmg commented Jan 12, 2015

@rvagg merge as is and mark the improvement as low hanging fruit for any new contributors who happen to be good at DRYing up Ansible scripts?

@rvagg
Copy link
Member Author

rvagg commented Jan 12, 2015

yeah, sorry, got lost in so many other things, and I already have some ansible updates locally that I need to push!

rvagg added a commit that referenced this pull request Jan 12, 2015
Added Ubuntu host setup
@rvagg rvagg merged commit edc48e4 into master Jan 12, 2015
@rvagg rvagg deleted the ubuntu branch January 12, 2015 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants