Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible: update branch used in clean_binary_tmp.sh #2978

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

richardlau
Copy link
Member

Fixes: #2977
Refs: nodejs/node#33864

@F3n67u
Copy link
Member

F3n67u commented Jun 27, 2022

could you help me understand what is binary_tmp.git? I seared the build repo, but I have no idea what it is?

Update `clean_binary_tmp.sh` script to reference `main` instead of
`master`.

Fix up the `jenkins-workspace` role to run as the owner of the git
repository when disabling automatic gc.
@richardlau
Copy link
Member Author

could you help me understand what is binary_tmp.git? I seared the build repo, but I have no idea what it is?

It's how we transfer build artifacts from the compile job to the test jobs (which may not be running on the same machine as was used to compile).

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardlau richardlau merged commit 65b68ec into nodejs:main Jun 28, 2022
@richardlau richardlau deleted the branchrename branch June 28, 2022 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cross-compiler-rhel8-armv7-gcc-8-glibc-2.28: No space left on device
3 participants