Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jenkins: release 12.x on centos7-ppcle #1885

Merged
merged 1 commit into from
Sep 11, 2019
Merged

jenkins: release 12.x on centos7-ppcle #1885

merged 1 commit into from
Sep 11, 2019

Conversation

sam-github
Copy link
Contributor

13.x has been releasing on centos7-ppcle for months. Start releasing
12.x on centos7-ppcle now. 10.x and below is not changed.

We get a supported operating system and expanded platform support:

  1. The current release system, ubuntu14.04, has been EOL since April.
  2. The devtoolset-6 compiler tools are available on centos7, and allow
    building binaries that run on MORE old linux libc versions than the
    current binaries build with gcc.

@sam-github
Copy link
Contributor Author

I forgot to mention: we don't want to do this between the sec releases on the 15th, and the next 12.x on Aug 20, its not enough time to confirm its working.

I suggest landing this after the 09-03 12.x release, see nodejs/Release#435

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sam-github
Copy link
Contributor Author

@nodejs/build any concerns about this?

I'm calling it out because we don't usually change the O/S that we use to build a version except at the start of a new release line.

In this case, by using devtools, we are going to get better platform support, fixing complaints about our current builds not running on some older platforms -- they will after this change.

@sam-github
Copy link
Contributor Author

Once landed, test by kicking the nightly build.

13.x has been releasing on centos7-ppcle for months. Start releasing
12.x on centos7-ppcle now. 10.x and below is not changed.

We get a supported operating system and expanded platform support:
1. The current release system, ubuntu14.04, has been EOL since April.
2. The devtoolset-6 compiler tools are available on centos7, and allow
building binaries that run on MORE old linux libc versions than the
current binaries build with gcc.

PR-URL: #1885
Reviewed-By: Michael Dawson <[email protected]>
@sam-github sam-github merged commit 000da9a into nodejs:master Sep 11, 2019
@sam-github sam-github deleted the release-on-centos7-ppc branch September 11, 2019 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants