jenkins: add patch to work around 24966 #1671
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patch required to work around problem affecting coverage builds. 24966 is not related to coverage but a more general issue that manifests in the coverage builds.
|
@gdams could you review/approve so I can land this? |
|
@mhdawson rubber stamped it... do you still want to land, or should it close? |
|
The job https://ci.nodejs.org/view/Node.js%20Daily/job/node-test-commit-linux-coverage-daily still has Not sure if its still required or not though. Given that there is work towards a different coverage implementation I'd say we could just close. It may not longer be required and if we are going to EOL that job in the nearish future no point investing time to figure that out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch required to work around problem affecting
coverage builds. 24966 is not related to coverage
but a more general issue that manifests in the
coverage builds.
We need this in CI to be able to run coverage on more than one machine which we are trying to do as part of adding a coverage check to the main PR regression job.