Skip to content

Conversation

@fhemberger
Copy link
Contributor

@rvagg Sorry, missed the second part for the content redirect, first commit only serves English 404-fallback.

@fhemberger
Copy link
Contributor Author

fhemberger commented Dec 30, 2018

Can this be merged?

Also, someone from @nodejs/build might want to look at nodejs/nodejs.org#1940 (which would make this PR superfluous, but will have an impact on website build time).

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson mhdawson merged commit b70ff37 into nodejs:master Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants