Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible: python3 for freebsd (for linting) #1644

Merged
merged 1 commit into from
Jan 21, 2019
Merged

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Dec 19, 2018

/R= @cclauss

Copy link
Contributor

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do we get when we python3 --version ?

Is there a py37-pip ?

@cclauss
Copy link
Contributor

cclauss commented Dec 19, 2018

Related to #1639

@rvagg
Copy link
Member Author

rvagg commented Dec 19, 2018

$ python3 --version
Python 3.6.7

there is a python37 package but it looks like python3 has given us python36, and I can't find a pip for 37

@cclauss
Copy link
Contributor

cclauss commented Dec 19, 2018

✅ Let's stick with Python 3.6.7.

@cclauss
Copy link
Contributor

cclauss commented Dec 20, 2018

✅ This change should enable us to add the command: make lint-py PYTHON=python3

@cclauss
Copy link
Contributor

cclauss commented Dec 23, 2018

Do we need more approvals on this one?

@thefourtheye
Copy link

cc @nodejs/build

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thefourtheye
Copy link

I believe this is ready to be merged. Can anybody from @nodejs/build take a look at this and merge?

@refack
Copy link
Contributor

refack commented Jan 21, 2019

I'll run the playbook, update the job and if everything goes smoothly I'll merge.

@refack
Copy link
Contributor

refack commented Jan 21, 2019

So the workers are setup, and the a cloned-edited job works as expected. That is fails with:

PYTHONPATH=tools/pip python3 -m flake8 . \
	--count --show-source --statistics --select=E901,E999,F821,F822,F823 \
	--exclude=.git,deps,lib,src,tools/*_macros.py,tools/gyp,tools/inspector_protocol,tools/jinja2,tools/markupsafe,tools/pip
./test/fixtures/wpt/encoding/resources/single-byte-raw.py:3:52: F821 undefined name 'xrange'
  response.content = "".join(chr(byte) for byte in xrange(255))
                                                   ^
1     F821 undefined name 'xrange'
1
gmake: *** [Makefile:1295: lint-py] Error 1

A PR was opened in upstream WPT repo - web-platform-tests/wpt#14973
and in node core - nodejs/node#25614

@refack refack merged commit 383c093 into master Jan 21, 2019
@refack refack deleted the rvagg/freebsd-python3 branch January 21, 2019 17:02
@refack
Copy link
Contributor

refack commented Jan 21, 2019

Has been run on worker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants