-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ansible: python3 for freebsd (for linting) #1644
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do we get when we python3 --version ?
Is there a py37-pip ?
Related to #1639 |
there is a |
✅ Let's stick with Python 3.6.7. |
✅ This change should enable us to add the command: make lint-py PYTHON=python3 |
Do we need more approvals on this one? |
cc @nodejs/build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I believe this is ready to be merged. Can anybody from @nodejs/build take a look at this and merge? |
I'll run the playbook, update the job and if everything goes smoothly I'll merge. |
So the workers are setup, and the a cloned-edited job works as expected. That is fails with:
A PR was opened in upstream WPT repo - web-platform-tests/wpt#14973 |
Has been run on worker. |
/R= @cclauss