Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extraced decode-ref.js, add tests, add rc builds #126

Closed
wants to merge 0 commits into from

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Jun 30, 2015

allow for v3.0.0-rc1 type build numbers, this means we have to tag RC builds as such in the repo but that's a good idea anyway.

@rvagg rvagg force-pushed the decode-ref-for-rc-builds branch 2 times, most recently from 377ae70 to 726602c Compare June 30, 2015 10:42
@Starefossen
Copy link
Member

Sticking to the semver specification; RC versions should be labeled v3.0.0-rc.1.

@rvagg
Copy link
Member Author

rvagg commented Jul 5, 2015

Thanks for pointing that out @Starefossen, I hadn't noticed the dot separation of tags in the spec before tbh. Will adjust for rc.3.

@rvagg
Copy link
Member Author

rvagg commented Jul 5, 2015

Actually, getting feedback from @ljharb here would be useful before jumping straight in.

@ljharb
Copy link
Member

ljharb commented Jul 5, 2015

I'm fine with vX.Y.Z-rc.N as a format, as long as it stays consistent - if so, can that be updated on the existing iojs.org rc site?

@rvagg
Copy link
Member Author

rvagg commented Jul 5, 2015

the existing builds have rcN baked in so can't be changed, I could remove them from index.tab and index.json by changing the regexes in this PR, would that help? the next RC can be the first one supported by nvm then

@ljharb
Copy link
Member

ljharb commented Jul 5, 2015

hmm - if both formats are there it's going to be a huge pain. As long as either the archive files themselves are all the same convention, across both existing and new releases, or the old releases don't exist in index.tab, I think I should be alright.

Basically I want to avoid having to code in support for more than one convention/format.

@rvagg
Copy link
Member Author

rvagg commented Jul 13, 2015

I've gone ahead and adopted the vx.y.z-rc.n format in Jenkins, I've updated this PR and this is live on the server now. I also deleted the older RCs so now there's only rc.3 @ https://iojs.org/download/rc/

Unfortunately node-gyp also needed the same treatment in next, I've proposed that here and there will be an rc.4 for this: nodejs/node#2171

@rvagg rvagg closed this Jul 13, 2015
@rvagg rvagg deleted the decode-ref-for-rc-builds branch July 13, 2015 04:26
@mgol
Copy link

mgol commented Sep 4, 2015

Just a quick update - it will be https://nodejs.org/download/rc/ now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants