-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extraced decode-ref.js, add tests, add rc builds #126
Conversation
377ae70
to
726602c
Compare
Sticking to the semver specification; RC versions should be labeled |
Thanks for pointing that out @Starefossen, I hadn't noticed the dot separation of tags in the spec before tbh. Will adjust for rc.3. |
Actually, getting feedback from @ljharb here would be useful before jumping straight in. |
I'm fine with |
the existing builds have |
hmm - if both formats are there it's going to be a huge pain. As long as either the archive files themselves are all the same convention, across both existing and new releases, or the old releases don't exist in Basically I want to avoid having to code in support for more than one convention/format. |
726602c
to
e1506b2
Compare
I've gone ahead and adopted the Unfortunately node-gyp also needed the same treatment in |
e1506b2
to
ba5e075
Compare
Just a quick update - it will be https://nodejs.org/download/rc/ now. |
allow for
v3.0.0-rc1
type build numbers, this means we have to tag RC builds as such in the repo but that's a good idea anyway.