Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Kunal Pathak to Build WG #649

Closed
joaocgreis opened this issue Mar 14, 2017 · 4 comments
Closed

Add Kunal Pathak to Build WG #649

joaocgreis opened this issue Mar 14, 2017 · 4 comments

Comments

@joaocgreis
Copy link
Member

This issue is to discuss adding @kunalspathak to the Build WG.

Kunal has added Windows Server 2016 to our build matrix in CI (#587, libuv/libuv#1245) and will keep maintaining those servers.

We can have a vote on the next WG meeting if consensus is not reached here.

cc @nodejs/build
@mhdawson mhdawson mentioned this issue Mar 28, 2017
Closed
@joaocgreis
Copy link
Member Author

Approved in today's meeting (#660). I'll move forward with adding to secrets.

@kunalspathak can you file a PR adding yourself to the list in README.md?

kunalspathak added a commit to kunalspathak/build that referenced this issue Mar 28, 2017
@kunalspathak
doc: add Kunal Pathak to members
eb210f4 
Fixes: nodejs#649
@kunalspathak kunalspathak mentioned this issue Mar 28, 2017
Merged
gibfahn pushed a commit that referenced this issue Mar 31, 2017
@kunalspathak @gibfahn
doc: add Kunal Pathak to members
466c13a 
PR-URL: #663
Refs: #649
Reviewed-By: João Reis <[email protected]>
Reviewed-By: Gibson Fahnestock <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
Reviewed-By: Phillip Johnsen <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@joaocgreis
Copy link
Member Author

Can someone with permission add @kunalspathak to https://github.com/orgs/nodejs/teams/build ? (@jbergstroem @mhdawson perhaps)

@jbergstroem
Copy link
Member

Added!

@joaocgreis
Copy link
Member Author

Thanks! This is done then!

@jasnell jasnell mentioned this issue Apr 25, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joaocgreis @jbergstroem