-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI wrapper to rebase, pre-fill and run CI on PRs #325
Comments
Maybe add a commit message linting/validation step that makes sure the final message:
|
Excellent list by @Trott. I'd like to add:
It'd be really nice to have a LGTM validation/"check" (ok/not ok to land); but I think it's too hard to make realistic LGTM counts seeing how new commits could introduce new code. |
Convention has coalesced around putting the PR-URL as the first metadata item in pull requests, so much so that collaborators are now flagging other collaborators' commit messages when they don't do that. So let's make it official and document that the PR-URL should be first. Refs: nodejs/build#325 Refs: nodejs#6385
Cross ref: #705 There's an issue of racing with humans/concurrent jobs. That's where the concept of a queue comes into play. (#324 (comment)) |
Closing due to long period of inactivity. Feel free to re-open if this is a thing. I'm just trying to close stuff that has been ignored for sufficiently long that it seems likely it's not something we're going to get to. |
Spawned off #324 (comment)
The basic idea would be a CLI script that does:
The only step on which I'm unsure on how to do would be step 5. Can anyone think of a git workflow to add metadata to existing commits without
rebase --interactive
?cc: @jbergstroem
The text was updated successfully, but these errors were encountered: