-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PSA - added node-test-commit-arm-debug to node-test-commit #2837
Comments
I should have also noted that it will show as yellow until we investigate: nodejs/node#41204 |
Updated configuration for so that the debug build only runs if major version is less than or equal to 17 |
We usually do exclusions based on Node.js release lines in https://github.com/nodejs/build/blob/master/jenkins/scripts/VersionSelectorScript.groovy. |
As far as I understand the groovy selector allows us to not run based on machine tag (ex ubuntu2004), not sure how that translates to this case. If you have suggestion for an alternate change to the groovy script that would help illustrate what you are suggesting. |
So for example
So we can add a rule for |
Ok we can update the groovy script for the part related to the x86 containers. Interestingly if you look at the actual contained job, there was already a check for > version 8. I just added the second check for <= 17 So it looks like there is some configuration in the CI job as well. Maybe that was just missed? |
I'd imagine the existing condition predates the introduction of the groovy script. |
Full debug x64 builds have been unreliable in the CI in the sharedlibs containers and were recently "turned off" by making the job a no-op. However the job was still being started even if it didn't do anything but pass -- this change prevents Jenkins from starting `sharedlibs_debug_x64` runs. Refs: #2837
Opened #2925. |
Full debug x64 builds have been unreliable in the CI in the sharedlibs containers and were recently "turned off" by making the job a no-op. However the job was still being started even if it didn't do anything but pass -- this change prevents Jenkins from starting `sharedlibs_debug_x64` runs. Refs: #2837
This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made. |
Added node-test-commit-arm-debug job to node-test-commit as next step in: nodejs/node#41209.
It's configured to only run the build/test > 17, and otherwise just pass as a job.
Will close this once we turn off the x86 debug builds and all has run ok for a few days.
The text was updated successfully, but these errors were encountered: