Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade openssl to 1.1.1g on ubuntu1804_sharedlibs_openssl111_x64 #2363

Closed
bnoordhuis opened this issue Jun 22, 2020 · 4 comments
Closed

Upgrade openssl to 1.1.1g on ubuntu1804_sharedlibs_openssl111_x64 #2363

bnoordhuis opened this issue Jun 22, 2020 · 4 comments

Comments

@bnoordhuis
Copy link
Member

Refs: nodejs/node#33981 (comment) - this CI run specifically

I'm 90% sure that's caused by that buildbot using openssl 1.1.1b in /opt/openssl-1.1.1b. Can it be upgraded to 1.1.1g?

Alternatively, Ubuntu 18.04 has a security back-port of 1.1.1 according to https://launchpad.net/ubuntu/bionic/+source/openssl and that gets us closer to testing what the distros link against.

@richardlau
Copy link
Member

Yes, it can. Relevant lines in ansible are

ENV OPENSSL111DIR /opt/openssl-1.1.1b
RUN mkdir -p /tmp/openssl_1.1.1b && \
cd /tmp/openssl_1.1.1b && \
curl -sL https://www.openssl.org/source/openssl-1.1.1b.tar.gz | tar zxv --strip=1 && \
./config --prefix=$OPENSSL111DIR && \
make -j 6 && \
make install && \
rm -rf /tmp/openssl_1.1.1b

PR's welcome 😄.

@richardlau
Copy link
Member

(To clarify, the ansible template will first need to be updated and then one of https://github.com/nodejs/build#jenkins-admins will need to reansible the sharedlib containers.)

@rvagg
Copy link
Member

rvagg commented Jun 23, 2020

I'll do it. May as well do Alpine 3.12 while I'm there.

@rvagg
Copy link
Member

rvagg commented Jun 23, 2020

Upgraded to 1.1.1g, see #2364, but seeing failures on test-crypto-authenticated-stream on master, https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubuntu1804_sharedlibs_openssl111_x64/20939/, so I don't think the problem is in nodejs/node#33981, it's on master already.

@rvagg rvagg closed this as completed Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants