This repository has been archived by the owner on Nov 28, 2020. It is now read-only.
Core benchmark changes #194
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves the output csv file to the root of the workspace, so multiple can be saved across runs.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
gareth-ellis
added a commit
that referenced
this pull request
Feb 10, 2018
PR-URL: #194 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
|
landed as 2e39126 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made some changes a number of months ago in the core-benchmark branch, and the jenkins job has been running that branch for some time now.
It's confusing to be running things from a branch rather than master, so I would like to merge these changes into master, and then switch the jenkins job to run from master too.
As per #193 , once done any changes to this job i would like to stage in another branch (perhaps core-benchmark) and then we can test those changes before merging into master, so we can avoid people running into issues.