Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update SWC to v1.10.16 #174

Merged
merged 3 commits into from
Feb 18, 2025
Merged

Conversation

nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot commented Feb 13, 2025

This PR updates SWC to v1.10.16.
View the SWC changelog for more information.

@marco-ippolito
Copy link
Member

marco-ippolito commented Feb 13, 2025

@kdy1 I dont see the new flag deprecatedTsModuleAsError added in kdy1/swc@308f5d0 working.
Tests and snapshots should fail.

This test specifically https://github.com/nodejs/amaro/blob/main/test/index.test.js#L237
is still erased https://github.com/nodejs/amaro/blob/main/test/snapshots/index.test.js.snapshot#L21

@kdy1
Copy link
Member

kdy1 commented Feb 16, 2025

cc @magic-akari for #174 (comment)

@magic-akari
Copy link

@kdy1 I dont see the new flag deprecatedTsModuleAsError added in kdy1/swc@308f5d0 working. Tests and snapshots should fail.

This test specifically https://github.com/nodejs/amaro/blob/main/test/index.test.js#L237 is still erased https://github.com/nodejs/amaro/blob/main/test/snapshots/index.test.js.snapshot#L21

Thanks for bringing this up! Currently, the deprecatedTsModuleAsError option defaults to false. Would you mind adding this option to the https://github.com/nodejs/amaro/blob/main/src/transform.ts file?

@marco-ippolito
Copy link
Member

@kdy1 I dont see the new flag deprecatedTsModuleAsError added in kdy1/swc@308f5d0 working. Tests and snapshots should fail.

This test specifically https://github.com/nodejs/amaro/blob/main/test/index.test.js#L237 is still erased https://github.com/nodejs/amaro/blob/main/test/snapshots/index.test.js.snapshot#L21

Thanks for bringing this up! Currently, the deprecatedTsModuleAsError option defaults to false. Would you mind adding this option to the https://github.com/nodejs/amaro/blob/main/src/transform.ts file?

I did in this PR

@marco-ippolito marco-ippolito force-pushed the chore/update-swc-1.10.16 branch from d5d1cf8 to 6884d18 Compare February 16, 2025 09:41
@marco-ippolito
Copy link
Member

thanks it fixed the problem, should be good now

kdy1 pushed a commit to swc-project/swc that referenced this pull request Feb 17, 2025
@marco-ippolito marco-ippolito merged commit cfc3f00 into main Feb 18, 2025
11 checks passed
@marco-ippolito marco-ippolito deleted the chore/update-swc-1.10.16 branch February 18, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants