-
Notifications
You must be signed in to change notification settings - Fork 155
doc: request token for wiby #986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
cc: @nodejs/tsc |
legendecas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The requirement for requesting token via this method is limited to https://github.com/nodejs repositories.
Would you mind elaborating on why @nodejs-bot is needed in this process?
|
@legendecas we don't actually need @nodejs-bot. As I mentioned, the bot that has access to those repositories is @wiby-bot, so that's the one that can generate the tokens I need. I'm requesting this because someone with access to the @wiby-bot account posted this comment, so I assume the process needs to be handled here. The reason I need these tokens is because that's how the wiby package currently works, the tokens are used to create branches in those repositories and to read the status of commits. They're essential for getting all the tests in the repo to pass. Right now, I can't test that functionality, so every time I make changes, I have no way to know if I'm breaking the integration or not. Without those tokens, the tests fail, and that has blocked me from continuing to maintain the package. |
|
@nodejs/tsc, any way to unblock this? |
|
Hey, @nodejs/tsc, could you please review it? |
|
I think the questions still remain:
This is out of scope of the management of nodejs admin. @nodejs/package-maintenance @mhdawson @dominykas I'd appreciate if you could chime in to help moving this forward. FWIW, the current @wiby-bot account owners are https://github.com/nodejs/email/blob/02aa2cdad44a66c18529fd87dd80ebe7210585c7/iojs.org/aliases.json#L191-L197 |
|
Hey @nodejs/tsc, we can also store the token info in the package-maintenance repository, and have the group manage it, since technically this package is part of pkgjs and therefore under the working group’s direction |
Should fix nodejs/package-maintenance#629
This token should have push access to the following repositories:
The bot that has access to this is called @wiby-bot, and the access credentials are in Node.js's 1Password.