-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vote lifecycle workflows and scripts #1401
Conversation
I won't have time to review in detail but trust that @aduh95 with in good shape and think having it captured/documeted in the repo is better than no. Will add my Rubber Stamp LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Co-authored-by: Antoine du Hamel <[email protected]>
@aduh95 is this ready to land? |
This PR adds automation and documentation for vote initialisations, it adds automation to report invalid vote commits, and to close votes.
Code reviews are welcome, note that we should wait for the transfer of Caritat npm package to the
@node-core
scope to be completed before landing.Blocked on: nodejs/node-core-utils#704
Fixes: #1165