Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add minutes for meeting 8 April 2021 #1011

Merged
merged 6 commits into from
Apr 20, 2021
Merged

Conversation

mhdawson
Copy link
Member

@mhdawson mhdawson commented Apr 8, 2021

Signed-off-by: Michael Dawson [email protected]

meetings/2021-04-08.md Outdated Show resolved Hide resolved
@DeeDeeG
Copy link

DeeDeeG commented Apr 16, 2021

I think there is an indentation/nesting syntax issue. A couple of extra spaces before the *. Some PRs' main bullet points are nested as if they are discussion bullet points -- interspersed with discussion of other (to my eyes unrelated) PRs.

Under this bullet point:

* doc: mark callback-based fs API as legacy [#37948](https://github.com/nodejs/node/pull/37948)

There are two other PRs indented as if nested under that topic:

* http: significant performance regression on master [#37937](https://github.com/nodejs/node/issues/37937)
* lib: refactor Timeout, ImmediateList, TimersList to class [#37408](https://github.com/nodejs/node/pull/37408)

As someone who did not see the meeting, it is a bit hard to parse out the relationship of said bullet points., and which discussion bullet points go with which PR/topic.

(P.S. thanks for providing minutes and the transparency!)

meetings/2021-04-08.md Outdated Show resolved Hide resolved
@Trott
Copy link
Member

Trott commented Apr 17, 2021

I think there is an indentation/nesting syntax issue.

Thanks. I think I fixed it.

@mhdawson mhdawson merged commit a0b9b6a into nodejs:main Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants