Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update governance to reflect process #912

Closed
wants to merge 1 commit into from
Closed

Conversation

MylesBorins
Copy link
Contributor

For some time all releasers have been allowed to make
LTS releases and backport changes. These documentation updates
are not intended to change any processes but rather to reflect
the current reality of how the team is operating.

There is still a backporters team that allows non-releasers to
backport commits, that is not currently documented.

For some time all releasers have been allowed to make
LTS releases and backport changes. These documentation updates
are not intended to change any processes but rather to reflect
the current reality of how the team is operating.

There is still a backporters team that allows non-releasers to
backport commits, that is not currently documented.
@@ -164,7 +164,6 @@ reported to the TSC immediately so remedial action can be taken.**

For releasing on LTS release lines, releasers must:

* Be added as members of the GitHub [LTS team](https://github.com/orgs/nodejs/teams/lts)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change might require TSC approval since it changes Governance.md

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this dates back to when the group was the Long Term Support (LTS) group and this repository was called "lts" and before it was expanded to include current releases?

@@ -79,16 +79,13 @@ the working group does not automatically result in membership in these
teams. These teams are:

* Releasers team
* LTS team
* CITGM team
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if we should remove this as well or not... it seems like the maintenance of CITGM isn't just relasers anymore but not 100%


<!-- ncu-team-sync end -->

### Backporters team
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we may want to bring this back into the readme, but there was no documentation about the backporters team

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't we have branch protection rules to allow backporters to land things on the staging branches?

## Releasers team

<!-- ncu-team-sync.team(nodejs/releasers) -->

* [@bengl](https://github.com/bengl) - Bryan English
* [@BethGriggs](https://github.com/BethGriggs) - Bethany Nicolle Griggs
* [@BethGriggs](https://github.com/BethGriggs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* [@BethGriggs](https://github.com/BethGriggs)
* [@BethGriggs](https://github.com/BethGriggs) - Bethany Nicolle Griggs

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a result of ncu-team sync and probably related what is visible in @BethGriggs 's public profile.


<!-- ncu-team-sync end -->

### Backporters team
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't we have branch protection rules to allow backporters to land things on the staging branches?

## Releasers team

<!-- ncu-team-sync.team(nodejs/releasers) -->

* [@bengl](https://github.com/bengl) - Bryan English
* [@BethGriggs](https://github.com/BethGriggs) - Bethany Nicolle Griggs
* [@BethGriggs](https://github.com/BethGriggs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a result of ncu-team sync and probably related what is visible in @BethGriggs 's public profile.

Comment on lines -89 to -91
The Long Term Support (LTS) team manages the process/content of LTS releases
and the required backporting for these releases. Additions to the LTS
team needs sign off from the rest of the LTS team.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is an interesting reality vs ideal situation. For as long as I have been involved with the Release WG the LTS team has not been the team with permissions to do releases (even LTS releases) -- that's the releasers team. It is supposed to be the team that discusses/gets to decide LTS policy/process/content. It is not a requirement that all members of the Release WG become releasers.

It's a reasonable question as to whether we still need a LTS team distinct from the whole Release WG. I know I've pinged the LTS team in the past.

Release, like a number of other Working Groups, has the challenge of dwindling participation over time punctured by occasional drives to increase membership.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. We discussed a not long time ago that the distinction between backporters/lts-team might not be necessary anymore since all the releasers fall in the same group.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some related conversations in #547.

@@ -164,7 +164,6 @@ reported to the TSC immediately so remedial action can be taken.**

For releasing on LTS release lines, releasers must:

* Be added as members of the GitHub [LTS team](https://github.com/orgs/nodejs/teams/lts)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this dates back to when the group was the Long Term Support (LTS) group and this repository was called "lts" and before it was expanded to include current releases?

@MylesBorins
Copy link
Contributor Author

Closing as this never got traction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants