Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grant release team maintainer access to release-related tooling #557

Open
3 of 6 tasks
BethGriggs opened this issue Mar 26, 2020 · 15 comments
Open
3 of 6 tasks

Grant release team maintainer access to release-related tooling #557

BethGriggs opened this issue Mar 26, 2020 · 15 comments

Comments

@BethGriggs
Copy link
Member

BethGriggs commented Mar 26, 2020

#547 opened further questions about the structure of the Release WG. It has been discussed that release team should have some responsibility over release related tooling.

  • Grant @nodejs/releasers write access to release related tooling
    • changelog-maker
    • commit-stream
    • branch-diff
    • node-core-utils
    • citgm
@richardlau
Copy link
Member

richardlau commented Mar 26, 2020

FWIW There's a shadow @nodejs/citgm-admins team that is used to control edit access to the CITGM CI jobs. We can probably keep the name of that group as-is.

@MylesBorins
Copy link
Contributor

MylesBorins commented Mar 26, 2020 via email

@gdams
Copy link
Member

gdams commented Mar 27, 2020

+1

2 similar comments
@mhdawson
Copy link
Member

mhdawson commented Apr 1, 2020

+1

@joyeecheung
Copy link
Member

+1

@joyeecheung
Copy link
Member

BTW I opened nodejs/admin#488

@MylesBorins
Copy link
Contributor

If we don't want to move forward with this work we should probably close this issue

@richardlau
Copy link
Member

  • Grant release-automation write access to release related tooling
    • changelog-maker
    • branch-diff
    • node-core-utils

The last few times this issue has come up in Release WG meetings the consensus has been to add @nodejs/releasers to these repositories rather than creating a new team or repurposing the citgm team.

@BethGriggs BethGriggs changed the title Proposal to rename CITGM team to release-automation Grant release team maintainer access to release-related tooling May 5, 2022
@BethGriggs
Copy link
Member Author

This was discussed in #735. We no longer plan to rename the CITGM team. Instead, this issue can be closed once the releaser have been granted maintainer access to the mentioned repositories. I've updated the issue description accordingly.

@richardlau
Copy link
Member

richardlau commented May 5, 2022

@richardlau
Copy link
Member

Opened nodejs/node-core-utils#628 for node-core-utils.

@richardlau
Copy link
Member

Based on nodejs/citgm#901 (comment) I've added citgm to the list. I'll open an issue for it in the citgm repository.

@bengl
Copy link
Member

bengl commented May 5, 2022

Should https://github.com/nodejs/commit-stream be added to this list of repos?

@BethGriggs
Copy link
Member Author

Should https://github.com/nodejs/commit-stream be added to this list of repos?

Added commit-stream to the list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants