-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delaying v8.x semver-minor release #308
Comments
Agreed that we should allow time for a proper release candidate for the two mentioned semver-minors. I guess the question is whether the remaining semver patch commits warrant a semver patch release. cc @kasicka re. nodejs/node#16509 (comment) and nodejs/node#18625 |
What about releasing the semver-minors that are in the current rc as planned and delay the two mentioned commits to the next semver-minor (possibly make March also semver-minor)? |
@richardlau we've actively avoided doing multiple semver minors for LTS in the past. The next scheduled minor would be next quarter... we could do this but I don't like the precedent it sets |
My preference would be to delay by 1-2 weeks. |
@mhdawson I am open to that The current schedule has the 20th as the date for the next r.c, how do you think we should go about that? |
We've already delayed a week right? So in total this release would be 3 weeks late. In that case we probably just want to drop the March 6th release and do 8.10.1 on April 3rd instead.
|
@gibfahn would we potentially just want to push the release until the 6th? |
You mean the v8.10.0 release? I'm not opposed to doing that. |
I think that is what we should do to keep calendar simple
…On Mon, Feb 12, 2018, 4:52 AM Gibson Fahnestock ***@***.***> wrote:
@gibfahn <https://github.com/gibfahn> would we potentially just want to
push the release until the 6th?
You mean the v8.10.0 release? I'm not opposed to doing that.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#308 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAecV-rNZW2BL0ion6Nso_ALR4xbyqeHks5tUAnKgaJpZM4SAN0x>
.
|
+1 to pushing to the 6th as well. |
There are two semver minor PRs against 8.x that we would like to land (they are finally green), but have not had time to do a proper r.c.
nodejs/node#16413 (update V8 to 6.2)
nodejs/node#18622 (add support for openssl 1.1.0)
The release is planned for next Tuesday. I think we should delay.
We have a couple options
Thoughts?
The text was updated successfully, but these errors were encountered: