Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This dynamic require is a no-go in webpack environments #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

This dynamic require is a no-go in webpack environments #34

wants to merge 1 commit into from

Conversation

implausible
Copy link
Member

@implausible implausible commented Apr 2, 2019 •
edited
Loading

While this is convenient, it makes the library difficult to use with webpack and other bundlers.

@tbranyen
Copy link
Member

tbranyen commented Apr 2, 2019

Bummer, I think it could be fixed to work, but given this is meant for NodeGit I'm okay with the change.

@zookatron
Copy link

Any timeline on when we might be able to have this merged in? Looking forward to using this with webpack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@implausible @tbranyen @zookatron