Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache binary in system tmp #379

Closed
tbranyen opened this issue Jan 30, 2015 · 3 comments
Closed

Cache binary in system tmp #379

tbranyen opened this issue Jan 30, 2015 · 3 comments
Labels

Comments

@tbranyen
Copy link
Member

We should cache the binary in a system tmp directory so that repeated installations are significantly faster.

@maxkorp maxkorp added the Build label Feb 4, 2015
@maxkorp
Copy link
Collaborator

maxkorp commented Feb 14, 2015

http://nodejs.org/api/os.html#os_os_tmpdir
Although we may want to consider something like storing them relative to NPM's path somewhere, in case of use by nvm/nvmw or such, because then we have to worry about cross version caching. Either that or we have to keep track of it on its own.

I would add that after pulling from our cache (wherever it is), we should probably test load it, and if it fails, clean it out, so we don't get in some sort of loop of a bad build.

@tbranyen
Copy link
Member Author

tbranyen commented Mar 1, 2015

Opened an issue: mapbox/node-pre-gyp#149 as I think it makes more sense in that library than ours.

@tbranyen
Copy link
Member Author

Closing, we'll re-visit if the feature ever gets added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants