Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: cache in OS tmpdir #149

Open
tbranyen opened this issue Mar 1, 2015 · 1 comment
Open

Feature request: cache in OS tmpdir #149

tbranyen opened this issue Mar 1, 2015 · 1 comment

Comments

@tbranyen
Copy link

tbranyen commented Mar 1, 2015

It would be great if node-pre-gyp could cache the fetched bundle from Amazon S3 and simply default to that first if it matches version and whatever criteria node-pre-gyp uses to determine the filename.

Here's a reference issue in NodeGit where we thought of this: nodegit/nodegit#379

@springmeyer
Copy link
Contributor

Yes, this would be a nice feature. But it would need good tests to ensure that any corrupt or partially downloaded binaries would not cause headaches. Would you be interested in providing a pull request? See also one attempt at this over at #101 that never landed because a pull+tests was never provided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants