Open
Conversation
|
@puzrin Hello, what do you think about this fix? Is it possible to fix pica for Brave? |
Member
|
I don't like idea to generate "something" instead of predictable result. |
Thank you for the answer! |
|
How to throw an error when fingerprinting is detected? |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#229
Brave browser also have fingerprinting protection for canvas. But it seems like Brave only shifts colors a little bit, so Pica is unable to generate the image while the output image could be pretty good.
[12, 23, 34, 255, 45, 56, 67, 255]<- Original[13, 22, 34, 255, 45, 57, 66, 255]<- Brave[86, 206, 251, 191, 18, 101, 167, 28]<- FirefoxEach color part can have +-5 difference to the original value which works good with Brave browser and still able to detect Firefox fingerprinting protection.