add tests for multi member decompression #146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 1, 2018
puzrin
reviewed
Sep 4, 2018
|
|
||
|
|
||
| function a2s(array) { | ||
| return String.fromCharCode.apply(null, array); | ||
| } | ||
|
|
||
| function readMultiMemberStream(inputData) { |
There was a problem hiding this comment.
I don't understand why to you use helper with chunks here instead of direct single pako.inflate() call.
|
Because the single pako inflate call does not work.
…On Tue, Sep 4, 2018 at 3:38 PM Vitaly Puzrin ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In test/gzip_specials.js
<#146 (comment)>:
>
function a2s(array) {
return String.fromCharCode.apply(null, array);
}
+function readMultiMemberStream(inputData) {
I don't understand why to you use helper with chunks here instead of
direct single pako.inflate() call.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#146 (review)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAEgFRiVEsQgZB_Xdp8jBHZrJ7IxAQi7ks5uXwDggaJpZM4WWY2Q>
.
|
|
IMHO such reason is not correct. After the right issue fix single inflate call should work. |
|
1a68969 added test to branch as it's expected to be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some passing tests for decompressing multi-member files.
fixes #139 by showing that pako works as-is for decompressing
bgzipfiles.