-
-
Notifications
You must be signed in to change notification settings - Fork 768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix possible code execution in (already unsafe) load() #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... when object with executable toString() property is used as a map key
Is anyone getting a CVE for this issue? If not, I can do it. |
HDVinnie
added a commit
to HDInnovations/UNIT3D-Community-Edition
that referenced
this pull request
Apr 16, 2019
- https://www.npmjs.com/advisories/813 - nodeca/js-yaml#480 - no CVE at time of publish
This was referenced Apr 30, 2019
This was referenced May 4, 2019
Closed
This was referenced May 5, 2019
Open
This was referenced Mar 7, 2024
This was referenced Mar 20, 2024
This was referenced Mar 29, 2024
This was referenced May 5, 2024
Open
Open
This was referenced May 19, 2024
Open
This was referenced May 30, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Object with executable toString() property when used as a map key will execute that function.
This happens only for
load()
, which should not be used with untrusted data anyway.safeLoad()
is not affected because it can't parse functions.Example:
After this PR it would return
[object Object]
as if toString wasn't there.Dates are not affected, and if you for whatever reason are using custom types as keys (which is not supported very well), you can change internal class with
Symbol.toStringTag
bypassing added validation check.