-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace res.set() #1808
replace res.set() #1808
Conversation
This is OK for consistency! But I do not understand why it solves the problem.
|
if (contentRange) { | ||
headers = { | ||
...headers, | ||
'Content-Range': contentRange, | ||
'Accept-Ranges': 'bytes', | ||
'Content-Length': chunksize | ||
} | ||
res.statusCode = 206 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be set here on the response because when PREP activates, we need to ensure that the status code is still 206 on the response. This code will mean PREP will always use the default res.statusCode
value of 200 when sending a response.
After further testing, I believe the problem happens because I would revert all changes except L104 and L132, and look for why the render is misunderstanding the media-type. |
You are right. Good catch I will open an issue in |
Clean up status code for 206 case.
Made some changes, this will work for now. |
No description provided.