Skip to content

accept file-uploads through multipart/form-data requests without modifications #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 27, 2019
Merged

accept file-uploads through multipart/form-data requests without modifications #95

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b009b4c
check for empty form params coming in as upload
kastentx Feb 18, 2019
aa0c3e7
swap to formdata fork of swagger-js-codegen
kastentx Feb 18, 2019
c58aade
add file-type to deps
kastentx Feb 18, 2019
5ea91b4
delete package-lock.json
kastentx Feb 19, 2019
d1f52b2
updated deps
kastentx Feb 19, 2019
100b2b4
updated helper lib in deps
kastentx Feb 21, 2019
4c4387a
remove upgrade from deps
kastentx Feb 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/nodegen.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ var mustache = require('mustache');
var jsStringEscape = require('js-string-escape');
var obfuscator = require('javascript-obfuscator');
var csv = require('csv-string');
var CodeGen = require('swagger-js-codegen').CodeGen;
var CodeGen = require('swagger-js-codegen-formdata').CodeGen;
var jimp = require("jimp");

function createCommonFiles(templateDirectory, data) {
Expand Down
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,8 @@
"minimist": "1.2.0",
"mustache": "2.3.0",
"request": "2.83.0",
"swagger-js-codegen": "1.12.0",
"swagger-js-codegen-formdata": "^0.15.4",
"upgrade": "^1.1.0",
Copy link
Member

@kazuhitoyokoi kazuhitoyokoi Feb 25, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kastentx I think that upgrade module is not used in the code. Could you remove it if it is mistakenly added? (Could you give me the reason if it is needed?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. This was added in error.

"when": "3.7.8",
"yamljs": "0.3.0"
},
Expand Down
1 change: 1 addition & 0 deletions templates/swagger/node.js.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ module.exports = function (RED) {
nodeParam = node.{{&methodName}}_{{&camelCaseName}};
nodeParamType = node.{{&methodName}}_{{&camelCaseName}}Type;
parameters.{{&camelCaseName}} = nodeParamType === 'str' ? nodeParam || '' : RED.util.getMessageProperty(msg, nodeParam);
parameters.{{&camelCaseName}} = !!parameters.{{&camelCaseName}} ? parameters.{{&camelCaseName}} : msg.payload;
{{/isNotBodyParam}}
{{/parameters}}

Expand Down
3 changes: 2 additions & 1 deletion templates/swagger/package.json.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
],
"dependencies": {
"q": "1.5.1",
"request": "2.83.0"
"request": "2.83.0",
"file-type": "^10.7.1"
},
"devDependencies": {
"node-red": "0.18.7",
Expand Down