Skip to content

Conversation

@kazuhitoyokoi
Copy link
Member

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

Current node which is generated from swagger definition cannot catch error because node.error() has only first argument. To solve the problem, I added msg variable as the second argument.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the mailing list/slack team.
  • I have run grunt to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@coveralls
Copy link

Coverage Status

Coverage remained the same at 77.812% when pulling f39026b on kazuhitoyokoi:master-fixnodeerror into 6b88422 on node-red:master.

@kazuhitoyokoi
Copy link
Member Author

@HiroyasuNishiyama Could you consider merging the pull request before our summer vacation?

@kazuhitoyokoi kazuhitoyokoi added this to the v0.0.2 milestone Aug 28, 2018
@HiroyasuNishiyama HiroyasuNishiyama merged commit cf3a250 into node-red:master Sep 3, 2018
@kazuhitoyokoi kazuhitoyokoi deleted the master-fixnodeerror branch September 28, 2018 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants