Skip to content

BEP-520: Short Block Interval Phase One: 1.5#642

Merged
setunapo merged 6 commits intonode-real:mainfrom
blxdyx:short_block_interval
Mar 26, 2025
Merged

BEP-520: Short Block Interval Phase One: 1.5#642
setunapo merged 6 commits intonode-real:mainfrom
blxdyx:short_block_interval

Conversation

@blxdyx
Copy link
Collaborator

@blxdyx blxdyx commented Mar 18, 2025

BEP-520: Short Block Interval Phase One: 1.5. Pick from: bnb-chain/bsc#2932

}
}
}
PenalizeForDelayMining, err := p.isIntentionalDelayMining(chain, header)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why with P and not p?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small p is better

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isIntentionalDelayMining is more readable?

MatusKysel
MatusKysel previously approved these changes Mar 25, 2025
@setunapo setunapo merged commit 523be11 into node-real:main Mar 26, 2025
9 checks passed
@blxdyx blxdyx deleted the short_block_interval branch May 14, 2025 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments