release 4.1.0 -> master #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added test coverage using nyc
Remove statuses package, use built in http.STATUS_CODES
Replace exception library Should with Chai
Member
Author
|
For this release, I'd like to just publish this manually -- once #49 is reviewed and further worked on. It can be our strategy moving forward. |
Member
|
@HappyZombies yes I agree with manual publishing for this release, otherwise we would be stuck for a much longer time with outdated code. Currently reviewing this one |
jankapunkt
approved these changes
Nov 5, 2021
Member
jankapunkt
left a comment
jankapunkt
left a comment
There was a problem hiding this comment.
From what I've seen this is all the code I have already reviewed in the recent PRs without deviation. From my end this can be published.
Member
|
@jwerre can you please add your review so @HappyZombies can publish? I already approved. |
Contributor
|
@jankapunkt yes, I'll check this out today. Sorry for the delay. |
Member
Author
|
Published! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary 📖
This PR merges the changes from development into master.