Skip to content

Replaces jshint with eslint #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Parent: Development
merged 11 commits into from
Oct 13, 2021
Merged

Replaces jshint with eslint #30

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e650264
removed jshint added eslint
jwerre Oct 11, 2021
9ebf817
merge with development branch
jwerre Oct 11, 2021
0cf3b11
removed 'no-prototype-builtins' from eslint
jwerre Oct 11, 2021
b4e344d
tests validator is tested for all unicode ranges
jankapunkt Oct 12, 2021
f57f4c3
validator is add missing variable in is.uchar
jankapunkt Oct 12, 2021
615bd75
tests validator also test for multiple characters
jankapunkt Oct 12, 2021
c0e4ef1
eslint enable no-control-regex and disable only in validator
jankapunkt Oct 12, 2021
9775b39
tests validator is increase timeout
jankapunkt Oct 12, 2021
391fbef
added chai to is_test.js
jwerre Oct 12, 2021
2e4d14f
removed jshint
jwerre Oct 12, 2021
12f0a80
disallow the use of console
jwerre Oct 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 46 additions & 0 deletions .eslintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
{
"extends": "eslint:recommended",
"env": {
"node": true,
"mocha": true,
"es6": true
},
"parserOptions": {
"ecmaVersion": 9,
"sourceType": "module",
"ecmaFeatures" : {
"globalReturn": false,
"impliedStrict": true,
"jsx": false
}
},
"rules": {
"indent": [
"error",
2
],
"linebreak-style": [
"error",
"unix"
],
"quotes": [
"error",
"single"
],
"semi": [
"error",
"always"
],
"no-control-regex": "off",
"no-console": "off",
"no-unused-vars": [
"error",
{
"vars": "all",
"args": "none",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also think we should throw on unused args, at least the jshint did that before

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally don't think we should throw, it should be a warning.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I'd like to keep it this way. Though an arg may not be used it makes a function a bit more expressive when you can see what is available.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jwerre I thought this is thrown when an arg is defined but not used in the function body like so:

function dosomething (foo, bar) {
  console.log(foo) // bar is defined as arg but never used in the function
}

"ignoreRestSiblings": false
}
]
}
}

1 change: 0 additions & 1 deletion .jshintignore
View file
Open in desktop

This file was deleted.

26 changes: 0 additions & 26 deletions .jshintrc
View file
Open in desktop

This file was deleted.

24 changes: 12 additions & 12 deletions lib/grant-types/authorization-code-grant-type.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,21 +133,21 @@ AuthorizationCodeGrantType.prototype.getAuthorizationCode = function(request, cl
* @see https://tools.ietf.org/html/rfc6749#section-4.1.3
*/

AuthorizationCodeGrantType.prototype.validateRedirectUri = function(request, code) {
if (!code.redirectUri) {
return;
}
AuthorizationCodeGrantType.prototype.validateRedirectUri = function(request, code) {
if (!code.redirectUri) {
return;
}

var redirectUri = request.body.redirect_uri || request.query.redirect_uri;
var redirectUri = request.body.redirect_uri || request.query.redirect_uri;

if (!is.uri(redirectUri)) {
throw new InvalidRequestError('Invalid request: `redirect_uri` is not a valid URI');
}
if (!is.uri(redirectUri)) {
throw new InvalidRequestError('Invalid request: `redirect_uri` is not a valid URI');
}

if (redirectUri !== code.redirectUri) {
throw new InvalidRequestError('Invalid request: `redirect_uri` is invalid');
}
};
if (redirectUri !== code.redirectUri) {
throw new InvalidRequestError('Invalid request: `redirect_uri` is invalid');
}
};

/**
* Revoke the authorization code.
Expand Down
2 changes: 1 addition & 1 deletion lib/models/token-model.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ function TokenModel(data, options) {
this.customAttributes = {};

for (var key in data) {
if (data.hasOwnProperty(key) && (modelAttributes.indexOf(key) < 0)) {
if ( Object.prototype.hasOwnProperty.call(data, key) && (modelAttributes.indexOf(key) < 0)) {
this.customAttributes[key] = data[key];
}
}
Expand Down
2 changes: 1 addition & 1 deletion lib/token-types/bearer-token-type.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ BearerTokenType.prototype.valueOf = function() {
}

for (var key in this.customAttributes) {
if (this.customAttributes.hasOwnProperty(key)) {
if ( Object.prototype.hasOwnProperty.call(this.customAttributes, key) ) {
object[key] = this.customAttributes[key];
}
}
Expand Down
Loading