Stop stale errors from popping up causing spurious failures when reusing a kept-alive HTTPS connection #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmq20
changed the title
pmq20
changed the title
pmq20
changed the title
|
这个可以先不合，等看看能否在 iojs 层面处理。 |
pmq20
force-pushed
the
fix-openssl-errors
branch
from
a2aacd1 to
c5c51a1
Compare
| @@ -185,6 +197,7 @@ exports.requestWithCallback = function (url, args, callback) { | |||
| var agent = args.agent || exports.agent; | |||
|
|
|||
| if (parsedUrl.protocol === 'https:') { | |||
| workaround_clear_openssl_errors(); | |||
There was a problem hiding this comment.
I will add a optional to detect clean openssl errors.
|
iojs 层面处理尝试： |
pmq20
force-pushed
the
fix-openssl-errors
branch
from
c5c51a1 to
b2ab4b5
Compare
* Add a test for the bug of unwanted openSSL errors * bad_sign() would inject an error into OpenSSL's error stack * Second time of calling requestThunk would make the error be thrown * This stops stale errors from popping up later causing spurious failures * FIXME: remove me when upstream Node.js has fixed this bug
pmq20
force-pushed
the
fix-openssl-errors
branch
from
b2ab4b5 to
cd54e36
Compare
|
iojs 层面上的补丁落地了 |
|
👍 |
|
这个就不合并了。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Stale OpenSSL errors are thrown causing spurious failures when reusing a kept-alive HTTPS connection. A test has been added to reproduce this bug.
Solution
As a workaround, forcibly clear OpenSSL's error stack. This workaround could be removed when / if the upstream Node.js / io.js project has fixed this bug.