Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is it possible to use next available port? #15

Closed
gaearon opened this issue Mar 16, 2017 · 2 comments · Fixed by #16
Closed

Is it possible to use next available port? #15

gaearon opened this issue Mar 16, 2017 · 2 comments · Fixed by #16

Comments

@gaearon
Copy link
Collaborator

gaearon commented Mar 16, 2017

Before updating to 1.1.0, detect-port used to suggest the next available port (e.g. 3001 if I requested 3000 but it is busy). Now, it seems to always suggest random ports (e.g. I just got 49655).

Is it possible to preserve the old behavior of suggesting the next available port, or are there any downsides?
@gaearon gaearon mentioned this issue Mar 16, 2017
Closed
@fengmk2
Copy link
Member

fengmk2 commented Mar 16, 2017

OK, I will make it try to get next port 10 times.

fengmk2 added a commit that referenced this issue Mar 17, 2017
@fengmk2
fix: try to use next available port
796f675 
closes #15
@fengmk2 fengmk2 mentioned this issue Mar 17, 2017
Merged
fengmk2 added a commit that referenced this issue Mar 17, 2017
@fengmk2
fix: try to use next available port
637b0fd 
closes #15
fengmk2 added a commit that referenced this issue Mar 17, 2017
@fengmk2
fix: try to use next available port (#16)
817105e 
* fix: try to use next available port

closes #15

* test: use egg-bin for test on node v4
@fengmk2
Copy link
Member

fengmk2 commented Mar 17, 2017

@gaearon Please take a try on [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: try to use next available port node-modules/detect-port
2 participants
@fengmk2 @gaearon