added os-name package #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var USER_AGENT = 'node/' + process.version | ||
| + ' (' + process.platform + ' ' + os.release() | ||
| + '; ' + process.arch + ')'; | ||
| var USER_AGENT = 'Node.js/' + process.version.slice(1) |
There was a problem hiding this comment.
How about using process.release nodejs/node#493 to support io.js also?
There was a problem hiding this comment.
Hmm, that's pretty new. They're not even sure yet where to put it and I don't see any examples of what its value would look like either. However, yes, supporting this would be a great idea when it's available.
There was a problem hiding this comment.
That new process.release Object should no longer be necessary now that io.js and Node.js have merged: http://www.infoq.com/news/2015/05/nodejs-iojs
There was a problem hiding this comment.
Ok, that new stuff was added to io.js v3.0.0, but what good is it to us when io.js is officially Node.js now?
|
+1 |
|
landed 66c8d4b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1.