Change execOverrides to Action<ExecSpec> #73
Conversation
- Stop downloading Node.js for each integration test project. We only test it once with a specified version and with the default version. Same thing for npm and yarn. - This means we rely on the tools installed globally on the system (this is a new development prerequisite). - Add new tests to ensure that we correctly use those globally installed tools. - Remove some tests that are duplicates of other ones (mostly for npm rule integration tests what test npm related features already tested elsewhere).
…er Gradle versions.
…, npm, npx and yarn tasks. Add an integration test using the Kotlin DSL to ensure it is correctly usable.
…en declaring environment variables.
…execOverrides option in the Groovy DSL as expected but it is no longer the case with the Kotlin DSL.
|
@deepy, I merged your I thought I already tested the Also, for some reason (which may be related to the Groovy DSL magic), your fix does not work with Gradle 5.0. I don't know exactly as of which version it works, but it works with Gradle 5.6.4. I could workaround this by skipping this test in Gradle 5. |
…ides property. It still does not work with Gradle < 5.6 (like the Groovy DSL).
|
I found a way to improve the compatibility with the Kotlin DSL but it still does not work with Gradle 5.0 (and probably other versions before Gradle 5.6.4). |
|
I close this pull request, I integrated it to #90. |
|
With Gradle 6 released I'm not sure we want to put too much effort into supporting 5.0. |
|
Yes. I read that Spring Boot 2.3 which will be released soon will support only Gradle 5.6 and 6. We can probably do the same thing. |
This hopefully fixes #72