Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relativize npm and npx symlinks #68

Merged
merged 1 commit into from
Feb 20, 2020

Conversation

bavardage
Copy link
Contributor

@bavardage bavardage commented Feb 18, 2020

Similar rationale as srs/gradle-node-plugin@5a392ad

We want to be able to make use of the unpacked node distribution in a place where the filesystem mapping is different, but seems this change didn't make it across to the kotlin rewrite.

@bavardage bavardage requested a review from deepy February 18, 2020 17:27
@bavardage bavardage force-pushed the bd/relativize-symlinks branch from 193e8b4 to c5fec0e Compare February 18, 2020 17:29
@bavardage bavardage requested a review from bsautel February 18, 2020 19:23
Copy link
Member

@deepy deepy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bavardage
Copy link
Contributor Author

@deepy what's the process for getting this merged & released?

@deepy
Copy link
Member

deepy commented Feb 19, 2020

Just want to verify it on the Mac tomorrow and then I can merge and release :-)

@deepy deepy merged commit 9b9038b into node-gradle:master Feb 20, 2020
@bavardage
Copy link
Contributor Author

amazing, thanks!

@deepy
Copy link
Member

deepy commented Feb 21, 2020

@bavardage 2.2.2 now exists 🎉

Thank you for your contribution :-)

@bsautel
Copy link
Contributor

bsautel commented Feb 29, 2020

Use the 2.2.3 version instead, it also contains the fix and the 2.2.2 one was broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants