Add taskRules flag to NodeExtension #117
Conversation
|
|
||
| this.project.afterEvaluate { | ||
| if (this.config.taskRules) { |
There was a problem hiding this comment.
not sure about this bit?
| @@ -33,6 +33,8 @@ class NodeExtension | |||
|
|
|||
| boolean download = false | |||
|
|
|||
| boolean taskRules = true | |||
There was a problem hiding this comment.
I think we might need a more descriptive name for this, but right now I can't think of a good one
There was a problem hiding this comment.
i went back and forth about it, it is a gradle plugin so in theory shouldn't be abstracting gradle concepts, task rules is the concept being configured. Could be 'dynamic task generation' or something but that is re-labelling something that already has a name.. a task rule 🤷♂️
There was a problem hiding this comment.
added some doco to solve for descriptiveness =)
|
Thanks for this PR. We will probably have to port it to the master branch because we did not plan to release new features in the 2.x version. |
|
i guess i could make it The reason you want it configurable is so you can turn it off? If you make it off by default that would change the contract for existing users of the plugin.. would break heaps of stuff? |
|
I personally prefer That's right, turning this option to false by default would break backward compatibility. But the version 3.0 already broke compatibility and it is still possible to integrate this change before its release. It's the reason why I think that we could afford to make this change. I am proposing that since if this feature is enable by default, you just have not to use it and that's it. What do you think about that? |
|
I like the name We could deprecate it in 3 and see if anyone complains about it, but it does add to the out-of-the-box experience in that you can just apply the plugin and get going immediately. |
| //if false (the default), it will enable Gradle Task Rules for `yarn_*`, `npm_*` and `npm_*` task names, | ||
| //to support automatic task creation. | ||
| //if true, it will not register task rules when the plugin is applied, | ||
| //so all rule-generated tasks will need to be configured manually (excluding static `yarn_setup`,`node_setup`,`npm_install`,`yarn_install`) |
There was a problem hiding this comment.
the static tasks don't use snake_case, they're all camelCase. e.g. yarnInstall, npmInstall, nodeSetup
|
This looks good to me, I'll test it tonight. I think we can do an additional I've been busy moving to a larger apartment and I've finally got enough room for the computer and gotten enough boxes away so that I can actually reach it. There's some proxy changes I've gotta finish first, but after that I can have a look at |
|
With this I can't configure tasks that are created from rules, e.g. the following does not work: So we can't merge this one into 2.x as it breaks backwards compatibility, we should still be able to get it into 3.x however. |
No description provided.