Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename nodeModulesDir? #99

Closed
bsautel opened this issue Apr 30, 2020 · 4 comments
Closed

Rename nodeModulesDir? #99

bsautel opened this issue Apr 30, 2020 · 4 comments
Milestone

Comments

@bsautel
Copy link
Contributor

bsautel commented Apr 30, 2020

When I was answering to #98, I realized that the nodeModulesDir's property name can be confusing. It can let us think that this is the path of the node_modules directory whereas it is the path of the directory containing the node_modules directory. It also contains the package.json directory.

I think that we should rename it before we release the 3.0 version, if we do it later, we will have to support both the new name and the former name. What about nodeProjectDir?

@bsautel bsautel added this to the 3.0 milestone Apr 30, 2020
@deepy
Copy link
Member

deepy commented May 4, 2020

Sounds great, but if we rename it we should add deprecated getter/setter for the old attribute so that a warning is triggered and the upgrade is less painful

@bsautel
Copy link
Contributor Author

bsautel commented May 5, 2020

Ok, thanks, I am going to do that.

bsautel added a commit that referenced this issue May 5, 2020
@bsautel bsautel closed this as completed May 5, 2020
bsautel added a commit that referenced this issue May 6, 2020
bsautel added a commit that referenced this issue May 6, 2020
@anapsix
Copy link

anapsix commented Jul 15, 2020

FYI: using version 2.2.4, when using nodeProjectDir instead of nodeModulesDir I'm getting an error

A problem occurred evaluating script.
> Could not set unknown property 'nodeProjectDir' for extension 'node' of type com.moowork.gradle.node.NodeExtension.

@bsautel
Copy link
Contributor Author

bsautel commented Jul 16, 2020

This change was done in the 3.0 version that is not yet released. In the 2.2.4 version, the property to use is nodeModulesDir.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants