-
-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename nodeModulesDir? #99
Comments
Sounds great, but if we rename it we should add deprecated getter/setter for the old attribute so that a warning is triggered and the upgrade is less painful |
Ok, thanks, I am going to do that. |
…a more explicit and less confusing name.
FYI: using version
|
This change was done in the 3.0 version that is not yet released. In the 2.2.4 version, the property to use is |
When I was answering to #98, I realized that the
nodeModulesDir
's property name can be confusing. It can let us think that this is the path of thenode_modules
directory whereas it is the path of the directory containing thenode_modules
directory. It also contains thepackage.json
directory.I think that we should rename it before we release the 3.0 version, if we do it later, we will have to support both the new name and the former name. What about
nodeProjectDir
?The text was updated successfully, but these errors were encountered: