-
-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can no longer see NpmTask.result #237
Comments
The history of why this was removed is in #144 (comment) Would the proposed alternative in #144 work for your use-case? |
As long as I can get "something that has the state about the task" after it fails, I think I can survive... It's not 100% clear what the proposed workaround is, an API for sending hooks to later receive the result object? I think I can survive w/ that... but, I feel like the original change "hey, lets remove the result from the task b/c stateful things are bad" is one of those "I'm making changes because I believe in a design pattern" rather than "I'm making a change that is going to improve how people can use this code". Tasks already are stateful. The are a big bag of state, they literally have a |
Sorry for the complaining before... is there anything I can do to help make this happen? |
No worries, the branch in #144 has suffered from the passage of time and doesn't merge cleanly any longer and I currently have limited spare time, I'll happily review and accept PRs. (for either solution) The only hard requirements currently is that it works on Next version is going to be a minor but after that I might have to drop |
It used to be possible to look at the
.result
of an invoked NpmTask, but upon updating to latest version, I see nothing is recording the returned exec resultplease store the result object from executeNpmCommand somewhere visible to buildscripts (on the task), so smart builds that want to inspect errors and make helpful suggestions can do so.
The text was updated successfully, but these errors were encountered: