Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin downloads wrong arch on PPC machine #166

Closed
akatona84 opened this issue Apr 22, 2021 · 4 comments
Closed

Plugin downloads wrong arch on PPC machine #166

akatona84 opened this issue Apr 22, 2021 · 4 comments

Comments

@akatona84
Copy link
Contributor

The detection of the architecture is not considering power pc machines.

@deepy
Copy link
Member

deepy commented Apr 22, 2021

None of us have access to a power pc machine, but if you can provide what java says for os.name and os.arch and what the result of uname -m is we can easily add it

where:
osProp | archProp | osName | osArch | isWindows
'Windows 8' | 'x86' | 'win' | 'x86' | true
'Windows 8' | 'x86_64' | 'win' | 'x64' | true
'Mac OS X' | 'x86' | 'darwin' | 'x86' | false
'Mac OS X' | 'x86_64' | 'darwin' | 'x64' | false
'Linux' | 'x86' | 'linux' | 'x86' | false
'Linux' | 'x86_64' | 'linux' | 'x64' | false
'SunOS' | 'x86' | 'sunos' | 'x86' | false
'SunOS' | 'x86_64' | 'sunos' | 'x64' | false

@akatona84
Copy link
Contributor Author

uname -m gives you ppc64le, I've asked to check os.arch which was the same (ppc64le), but didn't ask to check os.name property, it must be linux though. Will check just to be sure

@akatona84
Copy link
Contributor Author

Output of:

	System.out.println(System.getProperties().get("os.name"));
	System.out.println(System.getProperties().get("os.arch"));

is:

Linux
ppc64le

akatona84 added a commit to akatona84/gradle-node-plugin that referenced this issue Apr 22, 2021
deepy added a commit that referenced this issue Apr 23, 2021
Add support for Linux Power PC #166
@akatona84
Copy link
Contributor Author

Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants